Sync in ROMS recipes #523
Sync in ROMS recipes #523
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thanks for this @dgwyther, I'll have a look! Have you made a note in the notebooks about people who use the data to reach out to you? As a general note we can't enforce how people behave with publicly available data but we can always write what is an expectation. |
|
I see some commits of yours mention |
|
@dgwyther it would be easier if we review one-by-one in which case 4 PRs would be better. |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2025-06-17T01:16:43Z Line #11. delete empty lines? |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2025-06-17T01:16:44Z this is commented code; if we don't need it let's delete it. If we need it let's remove the comments? |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2025-06-17T01:16:45Z let's remove the method='local'? that won't work for anybody else other than you and it also has references to user-specific directories on gadi |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2025-06-17T01:16:46Z Line #18. # print('grd_file:', ds.attrs['grd_file'])
again, if it's important let's uncomment it; if it's not let's delete it? |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2025-06-17T01:16:46Z what is "QOL"? Let's spell it out?
|
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2025-06-17T01:16:47Z Line #14. if ds.Vtransform == 1: what is |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2025-06-17T01:16:48Z Line #1. weights = ds.dx*ds.dy
is |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2025-06-17T01:16:48Z Line #9. ax.plot(ds_clima.dayofyear,(ds_clima.m*60*60*24*365*mask_zice).weighted(weights).mean(dim={'eta_rho','xi_rho'}),label='Area mean melt rate',color='C0',linestyle='-',linewidth=1)
there seem to be a lot of multiplications with 60*60*24*365 let's define that a constant
eg something like:
|
|
I put some comments on the Few thoughts: Is this where people should be starting with ROMS? If so, then my general comment is that it seems a bit too elaborate? Perhaps we should first plot a field or two before we do all the shenanigans with xgcm? I'm all in about xgcm but at that point users perhaps aren't totally aware why do we need to do it? |
|
Hi @navidcy thank you so much for looking at this. I've been a bit light on the ground at conferences and so on (last week and next week), so I might be a bit slow to reply etc. I appreciate all of your suggestions. |
|
Perhaps we can Zoom quickly when you have some time to discuss a bit and find the best way? It's definitely a very welcome contribution!!!! |
Great - a zoom sounds like a good idea. Want to send me an email to organise? |
I've written 4 recipes that cover some of the basic and slightly more advanced procedures to deal with ROMS output. This includes loading data, setting up the coordinates, plotting and some basic analysis.
It is using output from a ROMS model of the Shackleton Ice Shelf that I have uplaoded into the intake catalog. I presented these results at a COSIMA meeting in March 2025. As per the entry in teh catalog, I have discussed some 'wishes' for correct use of the data with ACCESS-NRI staff, and come to the following terms of use: "PI Gwyther would like to be informed of studies using the ROMS Shackleton data. Depending on level of interest and how much a paper depends on the model results, co-authorship might be requested." I'm trying to find the balance between "total free use" and "this was a solo effort and I would appreciate co-authorship".