Skip to content

Convert Barotropic Streamfunction recipe to use only MOM6 #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2025
Merged

Convert Barotropic Streamfunction recipe to use only MOM6 #617

merged 2 commits into from
Sep 22, 2025

Conversation

minghangli-uni
Copy link
Contributor

For tips on creating and reviewing pull requests, see Some tips for reviewing on the documentation here.

Closes #593

@minghangli-uni minghangli-uni self-assigned this Sep 8, 2025
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@minghangli-uni minghangli-uni force-pushed the 593-covert-BS-use-mom6-only branch from 120e5a3 to acebebe Compare September 8, 2025 23:09
@minghangli-uni minghangli-uni added the 🎏 hackathon 5.0 Hackathon 2025 label Sep 8, 2025
minghangli-uni
minghangli-uni commented Sep 8, 2025
View reviewed changes
@minghangli-uni minghangli-uni force-pushed the 593-covert-BS-use-mom6-only branch 2 times, most recently from aed881c to a36890f Compare September 8, 2025 23:22
@minghangli-uni
Copy link
Contributor Author

unsure why I am not able to import cmocean, the projects I am loading are

gdata/ik11+scratch/tm70+gdata/tm70+gdata/vk83+gdata/qv56+gdata/oi10+gdata/ol01+gdata/fs38+gdata/p73+gdata/cj50+gdata/xp65+gdata/ol01+scratch/ol01

and modules are

/g/data/xp65/public/modules
conda/analysis3-25.05

Not sure if anything I am missing?

@edoddridge edoddridge self-requested a review September 9, 2025 01:37
edoddridge
edoddridge reviewed Sep 9, 2025
View reviewed changes
@edoddridge
Copy link
Collaborator

unsure why I am not able to import cmocean, the projects I am loading are

gdata/ik11+scratch/tm70+gdata/tm70+gdata/vk83+gdata/qv56+gdata/oi10+gdata/ol01+gdata/fs38+gdata/p73+gdata/cj50+gdata/xp65+gdata/ol01+scratch/ol01
and modules are

/g/data/xp65/public/modules
conda/analysis3-25.05
Not sure if anything I am missing?

Are you selecting that kernel in the notebook? I sometimes find that the notebook starts running with a different kernel. There should be a selector up near the top of the window with something like Python [conda environment_detials]

@minghangli-uni
Copy link
Contributor Author

Are you selecting that kernel in the notebook?

Ha, this does the trick! Thanks @edoddridge

@minghangli-uni minghangli-uni force-pushed the 593-covert-BS-use-mom6-only branch from a36890f to a3dd3aa Compare September 9, 2025 02:51
@minghangli-uni
Copy link
Contributor Author

@edoddridge would you like having another look?

@navidcy navidcy changed the title 593 covert bs use mom6 only Convert Barotropic Streamfunction recipe to use only MOM6 Sep 9, 2025
edoddridge
edoddridge reviewed Sep 19, 2025
View reviewed changes
@minghangli-uni minghangli-uni force-pushed the 593-covert-BS-use-mom6-only branch from a3dd3aa to ac769e5 Compare September 22, 2025 00:25
minghangli-uni and others added 2 commits September 22, 2025 10:27
@minghangli-uni @edoddridge
Convert Barotropic_Streamfunction.ipynb to use MOM6 only
b4cc3b5 
Co-authored-by: Ed Doddridge <edoddridge@users.noreply.github.com>
@minghangli-uni
Add Minghang Li to .zenodo.json
718aa24
@minghangli-uni minghangli-uni force-pushed the 593-covert-BS-use-mom6-only branch from ac769e5 to 718aa24 Compare September 22, 2025 00:27
@minghangli-uni
Copy link
Contributor Author

@edoddridge happy to have a final look, hopefully? :)

edoddridge
edoddridge approved these changes Sep 22, 2025
View reviewed changes
Copy link
Collaborator

@edoddridge edoddridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minghangli-uni minghangli-uni merged commit 1e662a8 into main Sep 22, 2025
3 checks passed
@minghangli-uni minghangli-uni deleted the 593-covert-BS-use-mom6-only branch September 22, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoddridge edoddridge edoddridge approved these changes

@PaulSpence PaulSpence Awaiting requested review from PaulSpence

Assignees

@minghangli-uni minghangli-uni

Labels
🎏 hackathon 5.0 Hackathon 2025
Projects
COSIMA Hackathon v5.0 🧑🏻‍💻👩🏾‍💻
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Barotropic_Streamfunction.ipynb to use MOM6 only
2 participants
@minghangli-uni @edoddridge