Skip to content

Conversation

adityarn
Copy link
Collaborator

@adityarn adityarn commented Sep 9, 2025

This is in response to an open issue raised as part of the COSIMA 2025 Hackathon. I've added latitude and longitude gridlines and tick labels to the plots.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@edoddridge
Copy link
Collaborator

Rather than linking to the issue, if you type something like closes #575, then the issue will be automatically closed when this PR is merged.

@edoddridge edoddridge self-requested a review September 9, 2025 04:29
Copy link

review-notebook-app bot commented Sep 9, 2025

View / edit / reply to this conversation on ReviewNB

edoddridge commented on 2025-09-09T05:07:57Z
----------------------------------------------------------------

Line #7.    gl = ax.gridlines(draw_labels=True)

The specification for which labels to draw isn't working perfectly at the moment. There are two labels that still get plotted on the right (60°N and 60°S) despite the

gl.right_labels = False # turn off right labels line.

Unfortunately it seems like there is an issue with cartopy that is making this hard to fix. I think it's probably fine to have the 60° labels printed on the right - they don't get in the way of the colour bar and I haven't been able to work out how to have them only on the left.


Copy link

review-notebook-app bot commented Sep 9, 2025

View / edit / reply to this conversation on ReviewNB

edoddridge commented on 2025-09-09T05:07:57Z
----------------------------------------------------------------

Line #44.            0, 0.95, "(" + string.ascii_lowercase[n] + ")", transform=ax.transAxes, size=16

The subplot labels look a little squished to me - I'd be tempted to bump them up a little farther.


Copy link

review-notebook-app bot commented Sep 9, 2025

View / edit / reply to this conversation on ReviewNB

edoddridge commented on 2025-09-09T05:07:58Z
----------------------------------------------------------------

Adding lines and labels to this plot?


Copy link

review-notebook-app bot commented Sep 9, 2025

View / edit / reply to this conversation on ReviewNB

edoddridge commented on 2025-09-09T05:07:59Z
----------------------------------------------------------------

Add lines and labels to this plot?


@edoddridge
Copy link
Collaborator

Rather than plotting all the labels and then turning off some of them, you could change the specification in the call to be:
gl = ax.gridlines(draw_labels=['left', 'bottom', 'x', 'y', 'geo'])

@navidcy
Copy link
Collaborator

navidcy commented Sep 9, 2025

Also, @adityarn you should add your details in the .zenodo.json file.

@adityarn
Copy link
Collaborator Author

adityarn commented Sep 9, 2025

Thanks Ed and Navid. I'll work on the edits and uupdate the PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants