Skip to content

Conversation

KZCurtin
Copy link
Collaborator

@KZCurtin KZCurtin commented Sep 9, 2025

Addressing the issues on the Hovmoller_Temperature_Depth notebook in 02_Appetisers (as per Hackathon issues list). I have:

  • Removed the salinity code and plot.
  • Added documentation at the top of the recipe with MOM6 variable names for assistance with converting to MOM6.
  • Also removed uses of cf-xarray.

Closes #595.

--

For tips on creating and reviewing pull requests, see Some tips for reviewing on the documentation here.

@KZCurtin KZCurtin self-assigned this Sep 9, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@KZCurtin KZCurtin requested review from navidcy and adele-morrison and removed request for navidcy September 9, 2025 04:58
@@ -6,7 +6,36 @@
"source": [
Copy link
Collaborator

@hrsdawson hrsdawson Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest a slight rewording to remove salinity: "... Hovmoller plot of annual, globally-averaged anomalies of conservative temperature from..."


Reply via ReviewNB

@@ -6,7 +6,36 @@
"source": [
Copy link
Collaborator

@hrsdawson hrsdawson Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe before the "To convert to.." line, we should first specify that this script is written for MOM5 output.


Reply via ReviewNB

@@ -6,7 +6,36 @@
"source": [
Copy link
Collaborator

@hrsdawson hrsdawson Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should update this to calculate the anomalies relative to the climatology, rather than the first year?

Although if the goal is to see model drift over time, then this current approach is appropriate. So maybe we can leave as it with this clarification ("this approach shows model drift over time").


Reply via ReviewNB

@@ -6,7 +6,36 @@
"source": [
Copy link
Collaborator

@hrsdawson hrsdawson Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think(?) the area of a grid cell varies with depth in MOM5 so perhaps for clarity we should remove that here.


Reply via ReviewNB

@@ -6,7 +6,36 @@
"source": [
Copy link
Collaborator

@hrsdawson hrsdawson Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could simplify this whole section and load the cell area variable directly (area_t) rather than calculating with dxt and dyt.


Reply via ReviewNB

@@ -6,7 +6,36 @@
"source": [
Copy link
Collaborator

@hrsdawson hrsdawson Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "where T is the globally averaged temperature anomaly"


Reply via ReviewNB

@@ -6,7 +6,36 @@
"source": [
Copy link
Collaborator

@hrsdawson hrsdawson Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #8.        fig = plt.figure(figsize = (10, 6))

Now that the salinity subplot is removed, we could expand the width dimension to see more of the temporal changes.


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Simplify and add MOM6 instructions to Hovmoller_Temperature_Depth.ipynb
2 participants