-
Notifications
You must be signed in to change notification settings - Fork 75
Updating Hovmoller recipe in Hackathon #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -6,7 +6,36 @@ | |||
"source": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest a slight rewording to remove salinity: "... Hovmoller plot of annual, globally-averaged anomalies of conservative temperature from..."
Reply via ReviewNB
@@ -6,7 +6,36 @@ | |||
"source": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe before the "To convert to.." line, we should first specify that this script is written for MOM5 output.
Reply via ReviewNB
@@ -6,7 +6,36 @@ | |||
"source": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should update this to calculate the anomalies relative to the climatology, rather than the first year?
Although if the goal is to see model drift over time, then this current approach is appropriate. So maybe we can leave as it with this clarification ("this approach shows model drift over time").
Reply via ReviewNB
@@ -6,7 +6,36 @@ | |||
"source": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think(?) the area of a grid cell varies with depth in MOM5 so perhaps for clarity we should remove that here.
Reply via ReviewNB
@@ -6,7 +6,36 @@ | |||
"source": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could simplify this whole section and load the cell area variable directly (area_t) rather than calculating with dxt and dyt.
Reply via ReviewNB
@@ -6,7 +6,36 @@ | |||
"source": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -6,7 +6,36 @@ | |||
"source": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #8. fig = plt.figure(figsize = (10, 6))
Now that the salinity subplot is removed, we could expand the width dimension to see more of the temporal changes.
Reply via ReviewNB
Addressing the issues on the Hovmoller_Temperature_Depth notebook in 02_Appetisers (as per Hackathon issues list). I have:
Closes #595.
--
For tips on creating and reviewing pull requests, see
Some tips for reviewing
on the documentation here.