Reduces compute time & fixes maps #626
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@polinaesia, the first comment in the PR is very descriptive -- nice! |
|
@navidcy I can't change the title, soz, will make it more informative next time |
|
This doesn't work for you? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR keeps plots stable by replacing Intake-attached
geolon_t/geolat_tonhtwith the unmaskedgeolon_t/geolat_tcoordinates from ocean_grid.nc (raised in #556). This is necessary because the coordinates currently attached by Intake are masked over continents (contain NaNs), and Cartopy fails to produce figure when x/y include NaNs (e.g. GEOSException: Points of LinearRing do not form a closed linestring)What's improved:
What needs fixing:
Ensure Intake loader attaches unmasked geolon_t/geolat_t
p.s. I also added Claire's note on MOM5-to-MOM6 conversion raised in
#581.