Mostly ERA5-GLORYS demo notebook tweaks #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
aekiss
commented
Apr 23, 2024
navidcy
reviewed
Apr 23, 2024
|
@aekiss, I see you make a note "not tested". (The CI tests that at least all cells runs... It doesn't check if they give out balony...) |
|
I'm working on resolving merge conflicts here... |
|
@aekiss, I move the ACCESS-OM2 example (with your edits) here -> COSIMA/cosima-recipes#338 |
navidcy
reviewed
Apr 23, 2024
| { | ||
| "cells": [ | ||
| { | ||
| "cell_type": "markdown", |
There was a problem hiding this comment.
Line #14. ## Directory where fre tools are stored, e.g. on NCI Gadi /home/157/ahg157/repos/mom5/src/tools/
we want to avoid referencing NCI which means nothing to most people
Reply via ReviewNB
navidcy
changed the title
navidcy
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somebody should test these before merging. Also check I haven't misunderstood anything.
I've tried to make the two notebooks more consistent.