Skip to content

Cleaning #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 93 commits into from
Closed

Cleaning #20

wants to merge 93 commits into from

Conversation

manoskary
Copy link
Member

This PR addresses cleaning and documentation.
It also creates notes to be corrected by reviewers:

  • NOTE Remark or comment to be reviewed for a function or Line;
  • TODO Potential Bug or enhancement, to be fixed or noted for later in a relevant issue with enhancement label;
  • CC and CARLOSREVIEW Comment particularly Addressed to @neosatrapahereje.

Hopefully by the end of the reviewing process issues #15 , #16 , #17 will be addressed and solved.

manoskary and others added 30 commits September 8, 2022 19:35
@manoskary
cleaned unused lines, functions and scripts, updated TODO.
2ee6643
@manoskary
cleaned unused lines.
02087b7
@manoskary
Primo match files.
5036d6b
@manoskary
cleaning unused imports and commented code.
0fa6857
@manoskary
Merge branch 'cleaning' of github.com:CPJKU/accompanion into cleaning
913b91a
@manoskary
added ACC pieces as submodule
ad23da7
@manoskary
Merge branch 'cleaning' of github.com:CPJKU/accompanion into cleaning
bd35206
@huispaty
Cleaned io_midi.py and utils_generic.py
b91d50d
@manoskary
updated readme and removed unused files.
b18c23f
@manoskary
Updated documentation for HMMAccompnion.
9de70aa
@manoskary
Updated documentation for HMMAccompnion.
46e4c4c
@manoskary
updated some docstrings, notes and todos on base accompanion.
a02d096
@manoskary
Merge branch 'cleaning' of github.com:CPJKU/accompanion into cleaning
bffb610
@manoskary
update doc strings on oltw version.
4fed93e
@manoskary
Annotate changes on Online DTW.
8de563e
@manoskary
Doc string for piano roll processor.
bfb7ad7
@manoskary
updated doc strings in IOIprocessor and pianorollprocessor.
3a6be5e
@manoskary
updated cython docstrings.
c1d20d5
@manoskary
Updated utils Docstrings.
c1fa74b
@manoskary
updated doc strings and comments.
a1b972f
@manoskary
updated doc strings and comments. Found an issue with Tempo Model not…
a49953d 
… initialized in the launch_acc.py.
@manoskary
Some notes on the existing Tempo Models.
f0a5792
@manoskary
IDK if this script is necessary.
4d3f7d1
@manoskary
updated launch to look into the submodule directory.
f7f7efd
@manoskary
Switched workflow run only for master for economy on Action hours.
9892225
@fosfrancesco
save midi option
6b0513b
@fosfrancesco
Merge remote-tracking branch 'origin/cleaning' into save_midi
d429c65
@fosfrancesco
New flag --record-midi-path that specifies wether to record the piano…
35f0f2d 
… input
@fosfrancesco
both input and output midi saved
b56a29c 
record_midi is now a boolean flag
name of the piece is in the output path
@manoskary
Merge pull request #19 from CPJKU/save_midi
e53de74 
This PR addresses MIDI I/O saving option for the accompanion.
CarlosCancino-Chacon and others added 28 commits October 10, 2022 16:01
@CarlosCancino-Chacon
delete commented lines in distances.pyx
7780785
@CarlosCancino-Chacon
removed unused math_utils.py
6f85b02
@CarlosCancino-Chacon
update .gitignore
c44dc7e
@CarlosCancino-Chacon
update .gitignore (ignore compiled cython code)
60693f6
@CarlosCancino-Chacon
remove notes and comments and blacken features_midi.py
387c37e
@CarlosCancino-Chacon
blacken accompaniment_decoder.py
6391699
@CarlosCancino-Chacon
deleted config/config.py and moved content to config/__init__.py
a0ce2cc
@CarlosCancino-Chacon
removed unused ModifiedScoresequencer
19a75f7
@CarlosCancino-Chacon
add documentation to ScoreSequencer
862147f
@CarlosCancino-Chacon
remove commented lines and redundant methods
8d812d0
@CarlosCancino-Chacon
minor fix import shadowed in loop variable
ed0d1fe
@CarlosCancino-Chacon
minor formatting
57baace
@CarlosCancino-Chacon
add documentation in MultiDTWscorefollower
849431f
@CarlosCancino-Chacon
minor remove unused variable in MultiDTWScorefollower
70b9421
@CarlosCancino-Chacon
updated loading scores for partitura 1.1.0
368d204
@fosfrancesco
corrected pedal bug in saving that shifted notes
fccc520
@fosfrancesco
round instead of int in the midi production
b075a2e
@fosfrancesco
correct args passing and midi_fn as overridable argument
08f46a1
@manoskary
Minor changes for midi playback.
81ee3cd
@nimrodVarga
Clarified a TODO regarding Issue #22
f0993d3
@CarlosCancino-Chacon
add BasePort class in midi_routing
0759273
@CarlosCancino-Chacon
Merge branch 'cleaning' of github.com:CPJKU/accompanion into cleaning
3ebb638
@nimrodVarga
implemented quasi-blocked wait for MIDI msgs, solving Keyboardinterru…
a6d323b 
…pts (again) and a previously faulty branching logic
@CarlosCancino-Chacon
add MultiOutputport (wip)
d5770d6
@CarlosCancino-Chacon
fix bug importing Empty
0f624c1
@CarlosCancino-Chacon
Merge pull request #24 from CPJKU/interrupt_midi_queue
d9f1b59 
Fix for Issue #22
@CarlosCancino-Chacon
Merge branch 'cleaning' of github.com:CPJKU/accompanion into cleaning
d5d4812
@huispaty
More cleaning, LTSM as default tempo model for OLTWACCompanion
578944b
@CarlosCancino-Chacon
Copy link
Member

This pull request is now obsolete, and its changes are now addressed by PR #27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosCancino-Chacon CarlosCancino-Chacon CarlosCancino-Chacon requested changes

Assignees

@manoskary manoskary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Partitura >1.0.0 Accompanion Pieces as a Submodule Current Version of ACCompanion is not robust with OLTW follower.
5 participants
@manoskary @CarlosCancino-Chacon @huispaty @fosfrancesco @nimrodVarga