Feat/color schemes rework #3878

ErikPre · 2025-11-04T15:01:59Z

Merging into Importer Rework branch

sonarqubecloud · 2025-11-04T15:04:05Z

Quality Gate passed

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

ErikPre · 2025-11-04T15:04:50Z

@tpurschke Ich habe die update sql erstmal 9.1.1.sql genannt, ich bin mir da nicht sicher in welche version und datei die kommt

Copilot

Pull Request Overview

This pull request adds a customizable color scheme feature to the UI, allowing users to select from predefined color schemes (blue, green, red, purple). The changes enable dynamic theming of the navigation bar and headings through CSS variables.

Introduced ColorScheme class with predefined color schemes and properties for gradient colors
Added color scheme selection UI in settings with persistence to configuration
Updated CSS to use CSS variables for dynamic color theming

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
roles/lib/files/FWO.Config.Api/Data/ColorScheme.cs	New class defining available color schemes with hex values and a lookup method
roles/lib/files/FWO.Config.Api/Data/ConfigData.cs	Added ColorScheme property to persist user's color scheme selection
roles/ui/files/FWO.UI/Services/ColorThemeService.cs	New service for managing user color mode state (appears unused in this PR)
roles/ui/files/FWO.UI/Shared/NavigationMenu.razor	Applied color scheme CSS variables to navigation bar for dynamic theming
roles/ui/files/FWO.UI/Pages/Settings/SettingsDefaults.razor	Added UI dropdown for color scheme selection with save functionality
roles/ui/files/FWO.UI/wwwroot/css/site.css	Updated gradient and heading styles to support CSS variables with fallbacks
roles/database/files/upgrade/8.8.11.sql	Database migration adding localized text entries for color schemes
roles/database/files/sql/idempotent/fworch-texts.sql	Added localized text entries for color scheme UI labels

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-04T15:06:21Z

roles/lib/files/FWO.Config.Api/Data/ColorScheme.cs

+using Org.BouncyCastle.Crypto.Engines;
+


The import Org.BouncyCastle.Crypto.Engines is unused in this file. This class only defines color scheme data structures and doesn't use any cryptographic functionality. Remove this unnecessary import.

Suggested change

using Org.BouncyCastle.Crypto.Engines;

yes, should be removed here

Copilot · 2025-11-04T15:06:21Z

roles/database/files/upgrade/8.8.11.sql

+INSERT INTO txt VALUES ('color_scheme_standard',        'German', 	'Standard Farbschema');
+INSERT INTO txt VALUES ('color_scheme_standard',        'English', 	'Standard Color Scheme');


The database migration includes text entries for 'color_scheme_standard', but this color scheme name doesn't exist in the ColorScheme.AvailableSchemes list. The actual default scheme is named 'color_scheme_blue'. Either add 'color_scheme_standard' as an available scheme or remove these unused text entries.

Suggested change

INSERT INTO txt VALUES ('color_scheme_standard', 'German', 'Standard Farbschema');

INSERT INTO txt VALUES ('color_scheme_standard', 'English', 'Standard Color Scheme');

Copilot · 2025-11-04T15:06:21Z

roles/database/files/sql/idempotent/fworch-texts.sql

+INSERT INTO txt VALUES ('notification',   		'German', 	'Benachrichtigung');
+INSERT INTO txt VALUES ('notification',   		'English', 	'Notification');
+INSERT INTO txt VALUES ('edit_notification',    'German', 	'Benachrichtigung bearbeiten');
+INSERT INTO txt VALUES ('edit_notification',    'English', 	'Edit Notification');
+INSERT INTO txt VALUES ('delete_notification',  'German', 	'Benachrichtigung l&ouml;schen');
+INSERT INTO txt VALUES ('delete_notification',  'English', 	'Delete Notification');


Lines 2669-2674 are duplicates of lines 2665-2668 (notification-related entries). These duplicate INSERT statements should be removed as they don't relate to the color scheme feature and will cause database constraint violations if the txt table has a unique constraint on the key-language combination.

Suggested change

INSERT INTO txt VALUES ('notification', 'German', 'Benachrichtigung');

INSERT INTO txt VALUES ('notification', 'English', 'Notification');

INSERT INTO txt VALUES ('edit_notification', 'German', 'Benachrichtigung bearbeiten');

INSERT INTO txt VALUES ('edit_notification', 'English', 'Edit Notification');

INSERT INTO txt VALUES ('delete_notification', 'German', 'Benachrichtigung löschen');

INSERT INTO txt VALUES ('delete_notification', 'English', 'Delete Notification');

Copilot · 2025-11-04T15:06:22Z

roles/ui/files/FWO.UI/Pages/Settings/SettingsDefaults.razor

            {
                configData.DefaultLanguage = selectedLanguage.Name;
+                configData.ColorScheme = selectedColorScheme.Name;
+                StateHasChanged();


Calling StateHasChanged() in the middle of the Save() method is unnecessary and could cause premature re-rendering before the save operation completes. If a state refresh is needed, it should be called after all data modifications are complete, or removed entirely if the framework handles it automatically after the async operation completes.

Suggested change

StateHasChanged();

Copilot · 2025-11-04T15:06:22Z

roles/ui/files/FWO.UI/Services/ColorThemeService.cs

+            bool allGood = false;
+            if (_UserColorModes.TryAdd(key, mode))
+            {
+                allGood = true;
+
+            }
+            else
+            {
+                allGood = _UserColorModes.TryUpdate(key, mode, _UserColorModes[key]);
+            }


Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.

Suggested change

bool allGood = false;

if (_UserColorModes.TryAdd(key, mode))

{

allGood = true;

}

else

{

allGood = _UserColorModes.TryUpdate(key, mode, _UserColorModes[key]);

}

bool allGood = _UserColorModes.TryAdd(key, mode)

? true

: _UserColorModes.TryUpdate(key, mode, _UserColorModes[key]);

tpurschke

see inline comments - @Y4nnikH maybe you can also have a look at Erik's 2 PRs

tpurschke · 2025-11-04T16:07:46Z

roles/database/files/upgrade/8.8.11.sql

all changes to txt table are made only in roles/database/files/sql/idempotent/fworch-texts.sql

tpurschke · 2025-11-04T16:08:53Z

roles/database/files/sql/idempotent/fworch-texts.sql

 INSERT INTO txt VALUES ('edit_notification',    'English', 	'Edit Notification');
 INSERT INTO txt VALUES ('delete_notification',  'German', 	'Benachrichtigung l&ouml;schen');
 INSERT INTO txt VALUES ('delete_notification',  'English', 	'Delete Notification');
+INSERT INTO txt VALUES ('notification',   		'German', 	'Benachrichtigung');


remove duplicates

tpurschke · 2025-11-04T16:09:20Z

roles/lib/files/FWO.Config.Api/Data/ColorScheme.cs

+using Org.BouncyCastle.Crypto.Engines;
+


yes, should be removed here

tpurschke · 2025-11-04T16:28:41Z

@tpurschke Ich habe die update sql erstmal 9.1.1.sql genannt, ich bin mir da nicht sicher in welche version und datei die kommt

I do not really see any file with that name but we do not need it anyway. Also the file 8.8.11 should be removed

ErikPre added 2 commits November 3, 2025 22:58

feat: Color into Rework branch

a453a51

Merge branch 'importer-rework' into feat/color-schemes-rework

9a31171

ErikPre requested review from Copilot and tpurschke November 4, 2025 15:02

Copilot AI reviewed Nov 4, 2025

View reviewed changes

tpurschke requested changes Nov 4, 2025

View reviewed changes

tpurschke marked this pull request as draft November 5, 2025 17:35

		INSERT INTO txt VALUES ('color_scheme_standard', 'German', 'Standard Farbschema');
		INSERT INTO txt VALUES ('color_scheme_standard', 'English', 'Standard Color Scheme');

Feat/color schemes rework #3878

Are you sure you want to change the base?

Feat/color schemes rework #3878

Uh oh!

Conversation

ErikPre commented Nov 4, 2025 • edited by tpurschke Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 4, 2025

Quality Gate passed

Uh oh!

ErikPre commented Nov 4, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

tpurschke Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

tpurschke left a comment

Choose a reason for hiding this comment

Uh oh!

tpurschke Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

tpurschke Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

tpurschke Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

tpurschke commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ErikPre commented Nov 4, 2025 •

edited by tpurschke

Loading