Merged
Conversation
Contributor
|
I've measured the actual time it takes to perform the occlusion culling on an average test scene with and without this patch after plenty of warmup, averaged over 5000 samples, and over multiple runs. |
Contributor
|
I'm interested in finally merging this, but there's a minor merge conflict. Also, would it be possible to use a (mixin) Accessor instead of reflection? |
90dafcd to
a4c630a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR precomputes section size into SimpleFrustum and skips far plane check to make it faster during RenderSectionManager.createTerrainRenderList
In Sparks time per tick mode createTerrainRenderList's time decreases from 10.75ms to 7.81ms and fps improves from 400 to about 500 when continuously moving mouse around with RD 40.
Reflection is used in this pr to access planes in FrustumIntersection