-
Notifications
You must be signed in to change notification settings - Fork 778
Potential fix for code scanning alert no. 87: String concatenation in loop #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -11,6 +11,7 @@ | |||||||||||
using System.Collections.Generic; | ||||||||||||
using System.Reflection; | ||||||||||||
using System.Threading.Tasks; | ||||||||||||
using System.Text; | ||||||||||||
#if XFORMS | ||||||||||||
using UIElement = global::Xamarin.Forms.Element; | ||||||||||||
using FrameworkElement = global::Xamarin.Forms.VisualElement; | ||||||||||||
|
@@ -176,11 +177,11 @@ | |||||||||||
} | ||||||||||||
#endif | ||||||||||||
|
||||||||||||
var message = method.Name; | ||||||||||||
var parameters = method.GetParameters(); | ||||||||||||
var messageBuilder = new StringBuilder(method.Name); | ||||||||||||
|
||||||||||||
if (parameters.Length > 0) { | ||||||||||||
message += "("; | ||||||||||||
messageBuilder.Append("("); | ||||||||||||
|
||||||||||||
foreach (var parameter in parameters) { | ||||||||||||
var paramName = parameter.Name; | ||||||||||||
|
@@ -189,15 +190,19 @@ | |||||||||||
if (MessageBinder.SpecialValues.ContainsKey(specialValue)) | ||||||||||||
paramName = specialValue; | ||||||||||||
|
||||||||||||
message += paramName + ","; | ||||||||||||
messageBuilder.Append(paramName).Append(","); | ||||||||||||
} | ||||||||||||
|
||||||||||||
message = message.Remove(message.Length - 1, 1); | ||||||||||||
message += ")"; | ||||||||||||
// Remove the trailing comma | ||||||||||||
if (parameters.Length > 0) | ||||||||||||
messageBuilder.Length -= 1; | ||||||||||||
messageBuilder.Append(")"); | ||||||||||||
var message = messageBuilder.ToString(); | ||||||||||||
|
||||||||||||
} | ||||||||||||
|
var message = messageBuilder.ToString(); | |
} | |
} | |
message = messageBuilder.ToString(); |
Copilot uses AI. Check for mistakes.
Check failure on line 204 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / Analyse
The name 'message' does not exist in the current context
Check failure on line 204 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / Analyse
The name 'message' does not exist in the current context
Check failure on line 204 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / Analyse
The name 'message' does not exist in the current context
Check failure on line 204 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / Analyse
The name 'message' does not exist in the current context
Check failure on line 204 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / Analyse
The name 'message' does not exist in the current context
Check failure on line 204 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / build
The name 'message' does not exist in the current context
Check failure on line 204 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / build
The name 'message' does not exist in the current context
Check failure on line 204 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / build
The name 'message' does not exist in the current context
Check failure on line 204 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / build
The name 'message' does not exist in the current context
Check failure on line 205 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / Analyse
The name 'message' does not exist in the current context
Check failure on line 205 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / Analyse
The name 'message' does not exist in the current context
Check failure on line 205 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / Analyse
The name 'message' does not exist in the current context
Check failure on line 205 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / Analyse
The name 'message' does not exist in the current context
Check failure on line 205 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / Analyse
The name 'message' does not exist in the current context
Check failure on line 205 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / build
The name 'message' does not exist in the current context
Check failure on line 205 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / build
The name 'message' does not exist in the current context
Check failure on line 205 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / build
The name 'message' does not exist in the current context
Check failure on line 205 in src/Caliburn.Micro.Platform/ViewModelBinder.cs
GitHub Actions / build
The name 'message' does not exist in the current context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition check is redundant since this code is already inside a block that only executes when
parameters.Length > 0
(line 183). The condition will always be true and can be removed.Copilot uses AI. Check for mistakes.