Skip to content

migrate to bzlmod module #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

dkthezero
Copy link

@dkthezero dkthezero commented Jun 24, 2024

Migrate the workspace to blzmod to release on Bazel Central Registry

@dkthezero dkthezero marked this pull request as ready for review June 24, 2024 21:39
@dkthezero dkthezero mentioned this pull request Jun 25, 2024
@Calsign
Copy link
Owner

Calsign commented Oct 7, 2024

This is good, but I would like to maintain support for legacy workspace mode as well (we're still using workspace at work). In this PR you've kept the workspace example around, but it doesn't work. I'm not familiar with the best way to approach supporting both bzlmod and workspace, so I'm not sure what it should look like yet. I can do this migration myself when I have time, but I don't have time at the moment.

@hofbi
Copy link

hofbi commented Apr 7, 2025

@Calsign as far as I understand, you want to maintain that the repo can be still consumed via workspace, correct? Because even with only bzlmod used in this repo, the project should be still able to be pull in in workspace files using http archive.

Given that with bazel 7 bzlmod is the default, and with bazel 8, workspace is disabled by default it might make sense to move forward with this repo as bazel only. Of course, we want to make sure that it can still be consumed correctly which could be done by an example.

@@ -17,4 +17,4 @@ build --config=clippy

build:ci --keep_going --experimental_scale_timeouts=3 --config=check

common --noenable_bzlmod
common --enable_bzlmod
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed as it is enabled by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants