Skip to content

Commit 3055909

Browse files
authored
Merge pull request #12365 from CesiumGS/review-to-be-close-to
Change `toBeCloseTo` to `toEqualEpsilon` where appropriate
2 parents a93e415 + 3896aea commit 3055909

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

packages/engine/Specs/Scene/I3SNodeSpec.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -698,17 +698,17 @@ describe("Scene/I3SNode", function () {
698698
expectedHeight,
699699
);
700700

701-
expect(cartographicOrigin.longitude).toBeCloseTo(
701+
expect(cartographicOrigin.longitude).toEqualEpsilon(
702702
expectedPosition.longitude,
703-
-3,
703+
CesiumMath.EPSILON3,
704704
);
705-
expect(cartographicOrigin.latitude).toBeCloseTo(
705+
expect(cartographicOrigin.latitude).toEqualEpsilon(
706706
expectedPosition.latitude,
707-
-3,
707+
CesiumMath.EPSILON3,
708708
);
709-
expect(cartographicOrigin.height).toBeCloseTo(
709+
expect(cartographicOrigin.height).toEqualEpsilon(
710710
expectedPosition.height,
711-
-3,
711+
CesiumMath.EPSILON3,
712712
);
713713
});
714714
});

packages/engine/Specs/Scene/OpenStreetMapImageryProviderSpec.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -168,19 +168,19 @@ describe("Scene/OpenStreetMapImageryProvider", function () {
168168
expect(provider.tileHeight).toEqual(256);
169169
expect(provider.maximumLevel).toBeUndefined();
170170
expect(provider.tilingScheme).toBeInstanceOf(WebMercatorTilingScheme);
171-
expect(provider.rectangle.west).toBeCloseTo(
171+
expect(provider.rectangle.west).toEqualEpsilon(
172172
rectangle.west,
173173
CesiumMath.EPSILON10,
174174
);
175-
expect(provider.rectangle.south).toBeCloseTo(
175+
expect(provider.rectangle.south).toEqualEpsilon(
176176
rectangle.south,
177177
CesiumMath.EPSILON10,
178178
);
179-
expect(provider.rectangle.east).toBeCloseTo(
179+
expect(provider.rectangle.east).toEqualEpsilon(
180180
rectangle.east,
181181
CesiumMath.EPSILON10,
182182
);
183-
expect(provider.rectangle.north).toBeCloseTo(
183+
expect(provider.rectangle.north).toEqualEpsilon(
184184
rectangle.north,
185185
CesiumMath.EPSILON10,
186186
);

packages/engine/Specs/Scene/TileMapServiceImageryProviderSpec.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -586,7 +586,7 @@ describe("Scene/TileMapServiceImageryProvider", function () {
586586

587587
expect(provider.rectangle.west).toEqual(expectedSW.longitude);
588588
expect(provider.rectangle.south).toEqual(expectedSW.latitude);
589-
expect(provider.rectangle.east).toBeCloseTo(
589+
expect(provider.rectangle.east).toEqualEpsilon(
590590
expectedNE.longitude,
591591
CesiumMath.EPSILON14,
592592
);
@@ -620,12 +620,12 @@ describe("Scene/TileMapServiceImageryProvider", function () {
620620
const expectedSW = Cartographic.fromDegrees(-123.0, -10.0);
621621
const expectedNE = Cartographic.fromDegrees(-110.0, 11.0);
622622

623-
expect(provider.rectangle.west).toBeCloseTo(
623+
expect(provider.rectangle.west).toEqualEpsilon(
624624
expectedSW.longitude,
625625
CesiumMath.EPSILON14,
626626
);
627627
expect(provider.rectangle.south).toEqual(expectedSW.latitude);
628-
expect(provider.rectangle.east).toBeCloseTo(
628+
expect(provider.rectangle.east).toEqualEpsilon(
629629
expectedNE.longitude,
630630
CesiumMath.EPSILON14,
631631
);
@@ -663,12 +663,12 @@ describe("Scene/TileMapServiceImageryProvider", function () {
663663
const expectedSW = Cartographic.fromDegrees(-123.0, -10.0);
664664
const expectedNE = Cartographic.fromDegrees(-110.0, 11.0);
665665

666-
expect(provider.rectangle.west).toBeCloseTo(
666+
expect(provider.rectangle.west).toEqualEpsilon(
667667
expectedSW.longitude,
668668
CesiumMath.EPSILON14,
669669
);
670670
expect(provider.rectangle.south).toEqual(expectedSW.latitude);
671-
expect(provider.rectangle.east).toBeCloseTo(
671+
expect(provider.rectangle.east).toEqualEpsilon(
672672
expectedNE.longitude,
673673
CesiumMath.EPSILON14,
674674
);
@@ -706,12 +706,12 @@ describe("Scene/TileMapServiceImageryProvider", function () {
706706
const expectedSW = Cartographic.fromDegrees(-123.0, -10.0);
707707
const expectedNE = Cartographic.fromDegrees(-110.0, 11.0);
708708

709-
expect(provider.rectangle.west).toBeCloseTo(
709+
expect(provider.rectangle.west).toEqualEpsilon(
710710
expectedSW.longitude,
711711
CesiumMath.EPSILON14,
712712
);
713713
expect(provider.rectangle.south).toEqual(expectedSW.latitude);
714-
expect(provider.rectangle.east).toBeCloseTo(
714+
expect(provider.rectangle.east).toEqualEpsilon(
715715
expectedNE.longitude,
716716
CesiumMath.EPSILON14,
717717
);

0 commit comments

Comments
 (0)