Skip to content

Fix issues with end-to-end tests #12653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix issues with end-to-end tests #12653

wants to merge 3 commits into from

Conversation

jjhembd
Copy link
Contributor

@jjhembd jjhembd commented Jun 4, 2025

Description

This PR fixes several issues affecting end-to-end tests:

  1. Updates playwright from 1.41 to 1.52. This update incorporates several breaking changes--Playwright is obviously not following semantic versioning.
  2. Updates playwright configuration to use the new Chromium headless implementation.
  3. Adds the --enable-features=Vulkan flag to the chromium project, to fix GPU acceleration on my machine (WSL Ubuntu on Windows 11)
  4. Fixes yargs syntax. We were using an older .argv getter which is no longer available in the ESM-only version 18.x (It had already been removed from the ESM versions much earlier).

TODO:

  • Verify on Mac and Linux
  • Discuss update strategy for playwright, add note to Release Guide

Issue number and link

Testing plan

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

github-actions bot commented Jun 4, 2025

Thank you for the pull request, @jjhembd!

✅ We can confirm we have a CLA on file for you.

@jjhembd jjhembd marked this pull request as ready for review July 29, 2025 19:13
@jjhembd jjhembd requested a review from mzschwartz5 July 29, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant