Cache SwiftSoup queries for notes, remove async #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of upcoming SwiftSoup changes, this converts the
FANotesPage
to non-asynchronous processing but speeds up the processing by caching the parsed queries.Once the next SwiftSoup version is out this can be further improved:
@preconcurrency
for theimport SwiftSoup
can be removed since theEvaluator
instances are going to be sendable.CssSelector.select(eval, node)
can be changed tonode.select(eval)
which is nicer to read.try elementsSelect(Self.titleQuery, baseNode.array())
can be replaced bybaseNode.select(Self.titleQuery)
and the helper function can be deleted.We could also wait for the next SwiftSoup version before merging this merge request and do the improvements mentioned above. I've created this merge request mostly as a demonstration so it doesn't get lost.