Fix return type annotations in _spectral.py #70
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update return type annotations for spectral derivative function.
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the return type annotations for the derivative function in exponax/_spectral.py. The function's return type was previously documented as returning arrays with shape (N//2)+1 in the last dimension, but this has been updated to N to accurately reflect the actual output shape.
Key Changes:
- Updated return type annotation from
(N//2)+1toNin the function signature - Updated corresponding documentation to match the corrected return type
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update return type annotations for spectral derivative function.