Skip to content

update ironic kernel append params #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2024
Merged

update ironic kernel append params #304

merged 2 commits into from
Sep 4, 2024

Conversation

msherman64
Copy link
Contributor

this PR has a couple of changes:

  1. in ironic, pxe_append_params is deprecated, so we need to replace it with kernel_append_params
  2. the nodemodeset and systemd.journald.forward_to_console options can both cause blocking and performance issues, so they have been removed.

Links to issues:
https://github.com/openstack/ironic/blob/e01522cd4ca02897bbecc4190ce128c5a344fd9f/releasenotes/notes/remove-nomodset-7a352a9519c1045b.yaml#L5

codyhammock
codyhammock approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@codyhammock codyhammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a straightforward update 👍🏻

@msherman64 msherman64 merged commit 03df984 into stable/2023.1 Sep 4, 2024
1 check passed
@msherman64 msherman64 deleted the wip/ironic_kernel_params branch October 16, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyhammock codyhammock codyhammock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msherman64 @codyhammock