Skip to content

Conversation

Mark-Powers
Copy link
Contributor

@Mark-Powers Mark-Powers commented Jan 27, 2025

This adds configuration needed for the blazar flavor plugin.

@Mark-Powers
Copy link
Contributor Author

@msherman64 Is there a way I can assert a condition on the defaults? I want to ensure
enable_host_reservation nand enable_flavor_reservation

@msherman64
Copy link
Contributor

@msherman64 Is there a way I can assert a condition on the defaults? I want to ensure enable_host_reservation nand enable_flavor_reservation

there's not really a way to do this within the defaults file / config file. You either need to do this in an ansible task (like in prechecks or config steps, in kolla-ansible), or via an external tool like ansible-lint. In chi-in-a-box itself, you're almost limited to the logic that jinja can do.

will blazar fail if both host_reservation and flavor_reservation are enabled?

@Mark-Powers
Copy link
Contributor Author

Main issue is that our host_reservation code assumes a lot about hosts, and the monitoring fails for some reason. I'm still digging into this.

@Mark-Powers Mark-Powers marked this pull request as ready for review January 30, 2025 17:22
default_share_type: cephfsnfstype

# Flavor reservation
enable_host_reservation: "{{ enable_nova | bool }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it be more clear and consistent to name these labels with "blazar_", e.g. "blazar_enable_host_reservation".

Copy link
Contributor

@msherman64 msherman64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mark-Powers Mark-Powers requested a review from pdmars as a code owner May 28, 2025 20:34
@Mark-Powers Mark-Powers removed the request for review from pdmars May 29, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants