[ironic] disable node history due to bug 2054594 #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for nodes getting stuck in "bad" states until restart of ironic conductor, as well as recovery from network-related errors. LP: https://bugs.launchpad.net/ironic/+bug/2054594 ironic uses a 32 character DB column for user_id, which is too short for the 64 character ids returned by keystone with federated login the real fix is a db migration, but that is hugely painful to try and backport from 2024.1. Instead, just diable the node_history feature, which seems to be the only thing in ironic writing 64 character IDs. Revert after upgrading to 2024.1.
msherman64
requested review from
pdmars,
Mark-Powers and
codyhammock
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for nodes getting stuck in "bad" states until restart of ironic conductor, as well as recovery from network-related errors.
LP: https://bugs.launchpad.net/ironic/+bug/2054594 ironic uses a 32 character DB column for user_id, which is too short for the 64 character ids returned by keystone with federated login
the real fix is a db migration, but that is hugely painful to try and backport from 2024.1. Instead, just diable the node_history feature, which seems to be the only thing in ironic writing 64 character IDs.
Revert after upgrading to 2024.1.