[horizon] set angular tempale cache expiry to 1d #343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when horizon starts up, it compresses angular template fragments for later speedups, and these compressed templates are later stored in the django cache, and also in browser caches. When the cache expires (default of 30d), the django cache is cleared, and a new cache generated. The cache url is based on the hash of the contents, and so a new url will be generated at this point if the content has changed, causing clients to pull it instead of using their browser cache. To work around serving stale data during upgrades/patches, we set this expiry to 1d (down from 30). Really, we should be ensuring that horizon re-compresses (and re-hashes) the templates before restarting, which should accomplish the same result. Details of operation are in: openstack/horizon@fca46ab
msherman64
requested review from
pdmars,
Mark-Powers and
codyhammock
as code owners
|
edit: this turns out to be helpful, but not actually the fix! horizon cache is regenerated if hash of config file changes. |
pdmars
approved these changes
May 1, 2025
Mark-Powers
approved these changes
May 1, 2025
|
Closing this, as we discovered that it's not actually responsible for regenerating the cache in our common cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when horizon starts up, it compresses angular template fragments for later speedups, and these compressed templates are later stored in the django cache, and also in browser caches.
When the cache expires (default of 30d), the django cache is cleared, and a new cache generated. The cache url is based on the hash of the contents, and so a new url will be generated at this point if the content has changed, causing clients to pull it instead of using their browser cache.
To work around serving stale data during upgrades/patches, we set this expiry to 1d (down from 30). Really, we should be ensuring that horizon re-compresses (and re-hashes) the templates before restarting, which should accomplish the same result.
Details of operation are in:
openstack/horizon@fca46ab