Skip to content

Replace old image deployer with new one #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 2, 2025
Merged

Replace old image deployer with new one #344

merged 8 commits into from
Jun 2, 2025

Conversation

pdmars
Copy link
Contributor

@pdmars pdmars commented May 22, 2025

No description provided.

Mark-Powers
Mark-Powers approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@Mark-Powers Mark-Powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

msherman64
msherman64 requested changes May 30, 2025
View reviewed changes
Copy link
Contributor

@msherman64 msherman64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this playbook as-is, authentication and image download don't seem to be working.
I've added a few commits to the end to fix this.

@msherman64
Copy link
Contributor

Does this work now if you start with an empty /etc/hammers directory? I wasn't sure how authentication had been working previously.

msherman64
msherman64 reviewed Jun 2, 2025
View reviewed changes
@pdmars
Copy link
Contributor Author

pdmars commented Jun 2, 2025

Does this work now if you start with an empty /etc/hammers directory? I wasn't sure how authentication had been working previously.

Yeah it did work for me, at least on my dev-in-a-box setup.

@pdmars pdmars requested a review from msherman64 June 2, 2025 16:38
msherman64
msherman64 approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@msherman64 msherman64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, looks good!

@pdmars pdmars merged commit 1192978 into stable/2023.1 Jun 2, 2025
1 check passed
@pdmars pdmars deleted the images/new-deployer branch June 2, 2025 18:32
msherman64 added a commit that referenced this pull request Jun 5, 2025
@msherman64
Merge pull request #350 from ChameleonCloud/wip/merge_new_image_deployer
90da7d7 
This PR removes the older image deployer + cleaner mechanism, and replaces it with our new one, which pulls from an object store more directly.

The merged playbook will also clean up the systemd timers from the old deployer, if present.
Note, the new mechanism does not currently have a "cleaner" tool, we will want to investigate that eventually for sites with less storage available.

This is a commit cleanup of #344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Powers Mark-Powers Mark-Powers approved these changes

@msherman64 msherman64 msherman64 approved these changes

@codyhammock codyhammock Awaiting requested review from codyhammock codyhammock is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdmars @msherman64 @Mark-Powers