Skip to content

Conversation

msherman64
Copy link
Contributor

No description provided.

fi

# install kolla-ansible galaxy deps. We use a subshell to drop back out of the venv afterwards
(source "${VIRTUALENV}/bin/activate" && kolla-ansible install-deps)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
Double quote array expansions to avoid re-splitting elements. SC2068

${POSARGS[@]}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [shellcheck] reported by reviewdog 🐶
Double quote array expansions to avoid re-splitting elements. SC2068

${POSARGS[@]}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
This function is never invoked. Check usage (or ignored if invoked indirectly). SC2329

_edit_passwords_cleanup() {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
ansible_path is referenced but not assigned. SC2154

playbook_file="$ansible_path/$(basename "$CC_ANSIBLE_PLAYBOOK")"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Not following: ./bin/activate: openBinaryFile: does not exist (No such file or directory) SC1091

source "${VIRTUALENV}/bin/activate"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant