Skip to content

Lua HTTPRequest fails to report callbacks' errors #6224

@ynot01

Description

@ynot01

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

When HTTPRequest's on_error() callback errors there is no information that it did. This makes debugging a bit nightmarish.

Screenshots

c2.register_command('/http', function()
    local r = c2.HTTPRequest.create(c2.HTTPMethod.Get, "http://localhost:8080")
    r:set_timeout(100)
    r:on_success(function(result)
        print('success callback')
        error('failed success')
    end)
    r:on_error(function(result)
        print('error callback')
        error('failed to fail')
    end)
    r:finally(function()
        print('finally callback')
        error('finally failed')
    end)
    r:execute()
end)

Notice that running this does not produce any feedback about errors in callbacks.

OS and Chatterino Version

Chatterino 2.5.3 (commit 3f3a31d) built with Qt 6.7.1, MSVC 194334808, Crashpad Running on Windows 11 Version 24H2, kernel: 10.0.26100

Metadata

Metadata

Assignees

No one assigned

    Labels

    Feature: EXPERIMENTAL PluginsStuff related to EXPERIMENTAL Lua plugin supportbugSomething isn't working as intended, or works in a confusing/unintuitive way for the user

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions