refactor(splits): Store container nodes as shared pointers #6435
+54
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
refactor/split-sp
branch
from
d98e50d to
e123e52
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| qreal totalSize = std::accumulate( | ||
| this->children_.begin(), this->children_.end(), qreal(0), | ||
| [=, this](int val, std::unique_ptr<Node> &node) { | ||
| [=, this](int val, const auto &node) { |
There was a problem hiding this comment.
warning: lambdas that capture 'this' should not specify a by-value capture default [cppcoreguidelines-misleading-capture-default-by-value]
Suggested change
| [=, this](int val, const auto &node) { | |
| [isVertical, totalFlex, minSize, this](int val, const auto &node) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to implement #5978, split container nodes need to be able to be passed to Lua. We could pass pointers, but that could result in a use-after-free. The object passed to Lua has to somehow know that a container node is no longer with us. We can do this with shared pointers (by giving Lua a weak reference to a node)
This PR refactors split nodes to use shared pointers to decouple from the Lua implementation.