Merged
Conversation
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos
commented
Mar 17, 2025
| * @param {typeof fetch} [options.fetchFn] Custom fetch function (useful for testing) | ||
| * @param {console['log']} [options.debugLog] Debug logger | ||
| */ | ||
| export function createJsonRpcClient(url, { requestHeaders, fetchFn } = {}) { |
Member
Author
There was a problem hiding this comment.
Oops, I was too quick to land this PR 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have too many places where we are duplicating the helper
assertOkResponse:https://github.com/search?q=org%3ACheckerNetwork%20assertOkResponse&type=code
Let's extract it into a shared npm package.