Skip to content

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Sep 4, 2024

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos requested a review from juliangruber September 4, 2024 08:08
@bajtos bajtos merged commit 80e7740 into main Sep 4, 2024
5 checks passed
@bajtos bajtos deleted the ci branch September 4, 2024 08:09
@bajtos
Copy link
Member Author

bajtos commented Sep 4, 2024

@juliangruber hindsight please 🙏🏻

Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why did you go for a multiple workspaces layout here?

push:
branches: [main]
pull_request:
branches: [main]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this limitation isn't necessary, as it prevents PRs targeting other branches from running CI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8

@bajtos
Copy link
Member Author

bajtos commented Sep 4, 2024

Out of curiosity, why did you go for a multiple workspaces layout here?

I should have explained that in the design doc.

Cross-posting #3 (comment):

Components:

  • indexer: background service owning the persisted data, similar to spark-evaluate and spark-observer
  • REST API server exposing that data - to be done later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants