fixup! address another review comment

bajtos · bajtos · commit 0a8b489843cc · 2024-11-21T14:52:15.000+01:00
Signed-off-by: Miroslav Bajtoš &lt;oss@bajtos.net&gt;
diff --git a/observer/bin/spark-observer.js b/observer/bin/spark-observer.js
@@ -51,8 +51,9 @@ const loop = async (name, fn, interval) => {
       point.intField('delay_ms', interval - dt)
     })
 
-    // This is safe to do because setTimeout(-10) has the same result as setTimeout(0)
-    await timers.setTimeout(interval - dt)
+    if (dt < interval) {
+      await timers.setTimeout(interval - dt)
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,9 @@ const loop = async (name, fn, interval) => {`
`51`	`51`	`point.intField('delay_ms', interval - dt)`
`52`	`52`	`})`
`53`	`53`
`54`		`- // This is safe to do because setTimeout(-10) has the same result as setTimeout(0)`
`55`		`- await timers.setTimeout(interval - dt)`
	`54`	`+ if (dt < interval) {`
	`55`	`+ await timers.setTimeout(interval - dt)`
	`56`	`+ }`
`56`	`57`	`}`
`57`	`58`	`}`
`58`	`59`