Skip to content

Commit 6089859

Browse files
author
Nikolas Haimerl
committed
change dependency and null test§
1 parent 2b5249e commit 6089859

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

stats/test/handler.test.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,12 @@ describe('HTTP request handler', () => {
7575

7676
it('returns today stats for no query string', async () => {
7777
const day = today()
78-
await givenRetrievalStats(pgPools.evaluate, { day, total: 10, successful: 1, successfulHttp: 1 })
78+
await givenRetrievalStats(pgPools.evaluate, { day, total: 10, successful: 1, successfulHttp: null })
7979
const res = await fetch(new URL('/retrieval-success-rate', baseUrl), { redirect: 'follow' })
8080
await assertResponseStatus(res, 200)
8181
const stats = await res.json()
8282
assert.deepStrictEqual(stats, [
83-
{ day, success_rate: 0.1, successful: '1', total: '10', successful_http: '1' }
83+
{ day, success_rate: 0.1, successful: '1', total: '10', successful_http: null, success_rate_http: null }
8484
])
8585
})
8686

@@ -101,8 +101,8 @@ describe('HTTP request handler', () => {
101101
await assertResponseStatus(res, 200)
102102
const stats = await res.json()
103103
assert.deepStrictEqual(stats, [
104-
{ day: '2024-01-11', success_rate: 0.05, successful: '1', total: '20', successful_http: '0' },
105-
{ day: '2024-01-12', success_rate: 0.1, successful: '3', total: '30', successful_http: '3' }
104+
{ day: '2024-01-11', success_rate: 0.05, successful: '1', total: '20', successful_http: '0', success_rate_http: 0 },
105+
{ day: '2024-01-12', success_rate: 0.1, successful: '3', total: '30', successful_http: '3', success_rate_http: 0.1 }
106106
])
107107
})
108108

@@ -164,8 +164,8 @@ describe('HTTP request handler', () => {
164164
await res.json()
165165
)
166166
assert.deepStrictEqual(stats, [
167-
{ day: '2024-01-10', success_rate: 51 / 110, total: '110', successful: '51', successful_http: '36' },
168-
{ day: '2024-01-11', success_rate: 61 / 220, total: '220', successful: '61', successful_http: '50' }
167+
{ day: '2024-01-10', success_rate: 51 / 110, total: '110', successful: '51', successful_http: '36', success_rate_http: 36 / 110 },
168+
{ day: '2024-01-11', success_rate: 61 / 220, total: '220', successful: '61', successful_http: '50', success_rate_http: 50 / 220 }
169169
])
170170
})
171171

@@ -186,8 +186,8 @@ describe('HTTP request handler', () => {
186186
await res.json()
187187
)
188188
assert.deepStrictEqual(stats, [
189-
{ day: '2024-01-10', success_rate: 5 / 10, total: '10', successful: '5', successful_http: '3' },
190-
{ day: '2024-01-20', success_rate: 1 / 10, total: '10', successful: '1', successful_http: '1' }
189+
{ day: '2024-01-10', success_rate: 5 / 10, total: '10', successful: '5', successful_http: '3', success_rate_http: 3 / 10 },
190+
{ day: '2024-01-20', success_rate: 1 / 10, total: '10', successful: '1', successful_http: '1', success_rate_http: 1 / 10 }
191191
])
192192
})
193193

@@ -208,7 +208,7 @@ describe('HTTP request handler', () => {
208208
await res.json()
209209
)
210210
assert.deepStrictEqual(stats, [
211-
{ day: '2024-01-20', success_rate: 1 / 10, successful: '1', total: '10', successful_http: '1' }
211+
{ day: '2024-01-20', success_rate: 1 / 10, successful: '1', total: '10', successful_http: '1', success_rate_http: 1 / 10 }
212212
])
213213
})
214214

@@ -220,7 +220,7 @@ describe('HTTP request handler', () => {
220220
await assertResponseStatus(res, 200)
221221
const stats = await res.json()
222222
assert.deepStrictEqual(stats, [
223-
{ day, success_rate: 0.1, successful: '1', total: '10', successful_http: '1' }
223+
{ day, success_rate: 0.1, successful: '1', total: '10', successful_http: '1', success_rate_http: 0.1 }
224224
])
225225
})
226226
})
@@ -429,8 +429,8 @@ describe('HTTP request handler', () => {
429429
await assertResponseStatus(res, 200)
430430
const stats = await res.json()
431431
assert.deepStrictEqual(stats, [
432-
{ miner_id: 'f1one', success_rate: 0.05, total: '20', successful: '1', successful_http: '0' },
433-
{ miner_id: 'f1two', success_rate: 0.75, total: '200', successful: '150', successful_http: '100' }
432+
{ miner_id: 'f1one', success_rate: 0.05, total: '20', successful: '1', successful_http: '0', success_rate_http: 0 },
433+
{ miner_id: 'f1two', success_rate: 0.75, total: '200', successful: '150', successful_http: '100', success_rate_http: 100 / 200 }
434434
])
435435
})
436436
})
@@ -703,8 +703,8 @@ describe('HTTP request handler', () => {
703703
await res.json()
704704
)
705705
assert.deepStrictEqual(stats, [
706-
{ day: '2024-01-10', success_rate: 1 / 10, total: '10', successful: '1', successful_http: '1' },
707-
{ day: '2024-01-20', success_rate: 1 / 20, total: '20', successful: '1', successful_http: '0' }
706+
{ day: '2024-01-10', success_rate: 1 / 10, total: '10', successful: '1', successful_http: '1', success_rate_http: 1 / 10 },
707+
{ day: '2024-01-20', success_rate: 1 / 20, total: '20', successful: '1', successful_http: '0', success_rate_http: 0 }
708708
])
709709
})
710710
})

0 commit comments

Comments
 (0)