Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 29, 2024

Bumps http-responders from 2.0.2 to 2.1.0.

Release notes

Sourced from http-responders's releases.

v2.1.0

  • add status(res, code) 090ba68
  • Bump got and np (#23) f65e43e
  • Bump braces from 3.0.2 to 3.0.3 (#22) a00ceb6
  • Bump word-wrap from 1.2.3 to 1.2.4 (#21) 57612a8

juliangruber/http-responders@v2.0.2...v2.1.0

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 29, 2024
@dependabot dependabot bot requested review from bajtos and juliangruber August 29, 2024 07:33
@github-actions github-actions bot enabled auto-merge (squash) August 29, 2024 07:33
Bumps [http-responders](https://github.com/juliangruber/http-responders) from 2.0.2 to 2.1.0.
- [Release notes](https://github.com/juliangruber/http-responders/releases)
- [Commits](juliangruber/http-responders@v2.0.2...v2.1.0)

---
updated-dependencies:
- dependency-name: http-responders
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/http-responders-2.1.0 branch from 8f2fc91 to ae419cc Compare August 29, 2024 07:43
@juliangruber
Copy link
Member

can you review please, @bajtos?

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 30, 2024

A newer version of http-responders exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Comment on lines -138 to -150
const notFound = (res) => {
res.statusCode = 404
res.end('Not Found')
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before, we set the response body to 'Not Found'.

What happens after the upgrade, when we call status(res, 404)? Will the status function set the response body to the status message corresponding with the status code?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export const status = (res, code) => {
  res.statusCode = code
  res.end(STATUS_CODES[code])
}

@github-actions github-actions bot merged commit ab48e09 into main Dec 6, 2024
9 checks passed
@github-actions github-actions bot deleted the dependabot/npm_and_yarn/http-responders-2.1.0 branch December 6, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants