Skip to content

feat(queries): fix use in operator regal lint issue #7359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

cx-artur-ribeiro
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro commented Feb 28, 2025

Fix use in operator regal lint issue

This PR replaces manual membership checks with the in operator in Rego files. This change improves code clarity, reduces the risk of logical errors, and enhances readability, especially when checking if a value is part of a collection.

Reason for Proposed Changes

  • Ensure compliance with Regal Linter’s use-in-operator rule;
  • Improve readability and maintainability by using the in operator for membership checks;
  • Reduce potential errors by making membership conditions more explicit.

Proposed Changes

  • Replace manual membership checks (e.g., x != []) with the in operator (e.g., x not in []);
  • Apply this change consistently across all affected Rego files;
  • Ensure all affected files pass Regal Linter without use-in-operator warnings.

Continuation of #7295

I submit this contribution under the Apache-2.0 license.

cx-artur-ribeiro and others added 29 commits February 23, 2025 12:48
@cx-artur-ribeiro cx-artur-ribeiro added the feature request Community: new feature request label Feb 28, 2025
@cx-artur-ribeiro cx-artur-ribeiro added feature New feature query New query feature community Community contribution labels Feb 28, 2025
@cx-artur-ribeiro cx-artur-ribeiro self-assigned this Feb 28, 2025
Copy link
Contributor

kics-logo

KICS version: v2.1.4

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-artur-ribeiro cx-artur-ribeiro marked this pull request as ready for review March 1, 2025 12:35
@cx-artur-ribeiro cx-artur-ribeiro requested a review from a team as a code owner March 1, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution feature request Community: new feature request feature New feature query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant