Skip to content

feat(queries): fix custom has key construct regal lint issue #7362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

cx-artur-ribeiro
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro commented Mar 1, 2025

Fix custom has key construct regal lint issue

This PR replaces custom key existence checks using the has_key function with the more efficient and idiomatic in operator and object.keys method. This change improves code readability, performance, and aligns with Rego best practices by eliminating the need for custom functions in favor of built-in constructs.

Reason for Proposed Changes

  • Ensure compliance with Regal Linter’s custom-has-key-construct rule;
  • Improve performance and readability by replacing custom functions with standard Rego constructs;
  • Align with Rego best practices and enhance maintainability by using idiomatic patterns for key existence checks.

Proposed Changes

  • Replace has_key(x, k) or exists(x,k) with k in object.keys(x) where appropriate;
  • Ensure all affected files pass Regal Linter without custom-has-key-construct warnings.

Continuation of #7295

I submit this contribution under the Apache-2.0 license.

cx-artur-ribeiro and others added 30 commits February 23, 2025 12:48
@cx-artur-ribeiro cx-artur-ribeiro added feature request Community: new feature request feature New feature query New query feature community Community contribution labels Mar 1, 2025
@cx-artur-ribeiro cx-artur-ribeiro self-assigned this Mar 1, 2025
Copy link
Contributor

github-actions bot commented Mar 1, 2025

kics-logo

KICS version: v2.1.4

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-artur-ribeiro cx-artur-ribeiro marked this pull request as ready for review March 1, 2025 15:50
@cx-artur-ribeiro cx-artur-ribeiro requested a review from a team as a code owner March 1, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution feature request Community: new feature request feature New feature query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant