Skip to content

Conversation

@AmineKhaldi
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@AmineKhaldi AmineKhaldi self-assigned this Oct 20, 2025
@AmineKhaldi AmineKhaldi added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Oct 20, 2025
@AmineKhaldi AmineKhaldi force-pushed the check_sb_validation_cost_fee_against_new_tx_cost branch from f3036e7 to 1af33c3 Compare October 20, 2025 17:05
@AmineKhaldi AmineKhaldi marked this pull request as ready for review October 21, 2025 16:12
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner October 21, 2025 16:12
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this approach is reliable or immediate enough. This validation should happen right after having validated the spend bundle

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 23, 2025
@AmineKhaldi AmineKhaldi force-pushed the check_sb_validation_cost_fee_against_new_tx_cost branch from 1af33c3 to 852590b Compare October 27, 2025 11:19
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 27, 2025
@AmineKhaldi AmineKhaldi force-pushed the check_sb_validation_cost_fee_against_new_tx_cost branch from 852590b to c58e097 Compare October 27, 2025 13:31
@AmineKhaldi AmineKhaldi force-pushed the check_sb_validation_cost_fee_against_new_tx_cost branch from c58e097 to 599d03f Compare October 28, 2025 15:55
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 18880943422

Details

  • 60 of 64 (93.75%) changed or added relevant lines in 6 files are covered.
  • 35 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.01%) to 90.749%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/full_node/full_node.py 9 10 90.0%
chia/full_node/full_node_api.py 16 19 84.21%
Files with Coverage Reduction New Missed Lines %
chia/full_node/pending_tx_cache.py 1 96.55%
chia/introducer/introducer.py 1 81.9%
chia/_tests/simulation/test_simulation.py 1 96.47%
chia/timelord/timelord_api.py 1 93.02%
chia/wallet/wallet_node.py 1 86.69%
chia/farmer/farmer_api.py 2 95.1%
chia/server/server.py 3 85.18%
chia/full_node/full_node_api.py 4 86.43%
chia/introducer/introducer_api.py 5 81.48%
chia/full_node/full_node.py 6 87.19%
Totals Coverage Status
Change from base Build 18847650880: -0.01%
Covered Lines: 102274
Relevant Lines: 112527

💛 - Coveralls

arvidn
arvidn previously approved these changes Oct 29, 2025
@arvidn
Copy link
Contributor

arvidn commented Oct 29, 2025

missing coverage:

chia/full_node/full_node.py (90.0%): Missing lines 2836
chia/full_node/full_node_api.py (84.2%): Missing lines 236,254,257

@AmineKhaldi AmineKhaldi force-pushed the check_sb_validation_cost_fee_against_new_tx_cost branch from 599d03f to bae4615 Compare October 29, 2025 10:47
@pmaslana pmaslana merged commit 9f62050 into Chia-Network:main Oct 29, 2025
827 of 833 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants