[LABS-293] Ensure wallet is synced for RPC TX endpoints #20190
Merged
+34
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
Quexington
changed the title
Quexington
commented
Oct 31, 2025
prozacchiwawa
approved these changes
Oct 31, 2025
markelrod
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many
@tx_endpoints implement this logic but not consistently. It makes sense to make sure the wallet is synced before proposing a potential change to a state you don't know the current state of. This change makes the check universal across transaction endpoints.There are some test changes as a result of this change that became necessary because this made poor state checking fail more consistently and thus caused many flakes. This is a good thing because it exposed areas that were probably slightly flaky before and locked them down to non-flaky behavior.