Skip to content

Conversation

@arvidn
Copy link
Contributor

@arvidn arvidn commented Oct 28, 2025

Purpose:

This PR collects a few minor changes, shaved off of my larger PR to integrate v2 plots.

These 3 commits are best reviewed one at a time, and are somewhat independent.

Current Behavior:

  • We still have some stub functions for the new chiapos2 API.
  • We use log.warning() and log.error() to log exceptions.
  • When farming v1 plots we always get the qualities, adjust them based on phase-out and check against difficulty.

New Behavior:

  • The last chiapos2 stub APIs have been removed.
  • We use log.exception() to log exceptions.
  • When farming v1 plots we short cut and ignore them if the block height is past the end of the phase-out. This is an optimization to avoid scanning the plots for proofs that will never pass the difficulty.

@arvidn arvidn requested a review from a team as a code owner October 28, 2025 13:30
@arvidn arvidn requested a review from almogdepaz October 28, 2025 13:30
@arvidn arvidn added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Oct 28, 2025
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 18877386781

Details

  • 8 of 12 (66.67%) changed or added relevant lines in 4 files are covered.
  • 44 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.03%) to 90.728%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/simulator/block_tools.py 2 3 66.67%
chia/plot_sync/receiver.py 2 5 40.0%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 85.95%
chia/full_node/pending_tx_cache.py 1 96.55%
chia/introducer/introducer.py 1 81.9%
chia/timelord/timelord_api.py 1 93.02%
chia/data_layer/data_layer.py 2 86.1%
chia/types/blockchain_format/proof_of_space.py 2 98.57%
chia/server/server.py 3 84.93%
chia/_tests/core/custom_types/test_proof_of_space.py 3 95.89%
chia/wallet/wallet_node.py 3 86.61%
chia/introducer/introducer_api.py 5 81.48%
Totals Coverage Status
Change from base Build 18847650880: -0.03%
Covered Lines: 102218
Relevant Lines: 112489

💛 - Coveralls

@arvidn
Copy link
Contributor Author

arvidn commented Oct 28, 2025

The test coverage for block_tools.py is because we don't run tests on v2 plots yet. It will be covered once we get there.

@arvidn arvidn force-pushed the minor-pos2-updates branch from c592631 to 0879516 Compare October 29, 2025 10:28
@arvidn arvidn requested a review from wjblanke October 29, 2025 10:49
@github-actions
Copy link
Contributor

File Coverage Missing Lines
chia/harvester/harvester_api.py 66.7% lines 404
chia/plot_sync/receiver.py 40.0% lines 116-117, 190
chia/simulator/block_tools.py 50.0% lines 1557
Total Missing Coverage
14 lines 5 lines 64%

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added ready_to_merge Submitter and reviewers think this is ready and removed coverage-diff labels Oct 29, 2025
@pmaslana pmaslana merged commit e191f0a into main Oct 29, 2025
636 of 641 checks passed
@pmaslana pmaslana deleted the minor-pos2-updates branch October 29, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants