Skip to content

use deep instead of shallow copy #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use deep instead of shallow copy #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 41 additions & 21 deletions src/nucomp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,21 +195,33 @@ void qfb_nucomp(qfb_t r, const qfb_t f, const qfb_t g, mpz_t const& D, mpz_t con
void nucomp_form(form &a, form const& b, form const& c, integer const& D, integer const& L) {
qfb fr, fr2, fr3;

*fr.a = *a.a.impl;
*fr.b = *a.b.impl;
*fr.c = *a.c.impl;
*fr2.a = *b.a.impl;
*fr2.b = *b.b.impl;
*fr2.c = *b.c.impl;
*fr3.a = *c.a.impl;
*fr3.b = *c.b.impl;
*fr3.c = *c.c.impl;
mpz_init_set(fr.a,a.a.impl);
mpz_init_set(fr.b,a.b.impl);
mpz_init_set(fr.c,a.c.impl);

mpz_init_set(fr2.a,b.a.impl);
mpz_init_set(fr2.b,b.b.impl);
mpz_init_set(fr2.c,b.c.impl);

mpz_init_set(fr3.a,c.a.impl);
mpz_init_set(fr3.b,c.b.impl);
mpz_init_set(fr3.c,c.c.impl);

qfb_nucomp(&fr, &fr2, &fr3, D.impl, L.impl);

*a.a.impl = *fr.a;
*a.b.impl = *fr.b;
*a.c.impl = *fr.c;
mpz_set(a.a.impl,fr.a);
mpz_set(a.b.impl,fr.b);
mpz_set(a.c.impl,fr.c);

mpz_clear(fr.a);
mpz_clear(fr.b);
mpz_clear(fr.c);
mpz_clear(fr2.a);
mpz_clear(fr2.b);
mpz_clear(fr2.c);
mpz_clear(fr3.a);
mpz_clear(fr3.b);
mpz_clear(fr3.c);
}

void qfb_nudupl(qfb_t r, qfb_t f, mpz_t D, mpz_t L)
Expand Down Expand Up @@ -329,18 +341,26 @@ void nudupl_form(form &a, form &b, integer &D, integer &L)
{
qfb fr, fr2;

*fr.a = *a.a.impl;
*fr.b = *a.b.impl;
*fr.c = *a.c.impl;
*fr2.a = *b.a.impl;
*fr2.b = *b.b.impl;
*fr2.c = *b.c.impl;
mpz_init_set(fr.a,a.a.impl);
mpz_init_set(fr.b,a.b.impl);
mpz_init_set(fr.c,a.c.impl);

mpz_init_set(fr2.a,b.a.impl);
mpz_init_set(fr2.b,b.b.impl);
mpz_init_set(fr2.c,b.c.impl);

qfb_nudupl(&fr, &fr2, D.impl, L.impl);

*a.a.impl = *fr.a;
*a.b.impl = *fr.b;
*a.c.impl = *fr.c;
mpz_set(a.a.impl,fr.a);
mpz_set(a.b.impl,fr.b);
mpz_set(a.c.impl,fr.c);

mpz_clear(fr.a);
mpz_clear(fr.b);
mpz_clear(fr.c);
mpz_clear(fr2.a);
mpz_clear(fr2.b);
mpz_clear(fr2.c);
}

#endif // NUCOMP_H
Loading