[Fusion] Support type-system directives (#7585)

Author: tobias-tengler

src/HotChocolate/Core/src/Types/Types/Extensions/DirectiveLocationExtensions.cs

@@ -36,6 +36,10 @@ public static class DirectiveLocationExtensions
                DirectiveLocation.InlineFragment,
                Language.DirectiveLocation.InlineFragment
            },
+           {
+               DirectiveLocation.VariableDefinition,
+               Language.DirectiveLocation.VariableDefinition
+           },
            {
                DirectiveLocation.Schema,
                Language.DirectiveLocation.Schema

src/HotChocolate/Fusion/src/Abstractions/FusionTypeBaseNames.cs

@@ -45,6 +45,16 @@ internal static class FusionTypeBaseNames
     /// </summary>
     public const string FusionDirective = "fusion";
 
+    public const string InternalDirective = "internal";
+
+    public const string RenameDirective = "rename";
+
+    public const string RemoveDirective = "remove";
+
+    public const string LookupDirective = "lookup";
+
+    public const string RequireDirective = "require";
+
     /// <summary>
     /// The base name of the GraphQL selection directive.
     /// </summary>

src/HotChocolate/Fusion/src/Abstractions/FusionTypeNames.cs

@@ -22,6 +22,11 @@ private FusionTypeNames(
         string reEncodeIdDirective,
         string transportDirective,
         string fusionDirective,
+        string internalDirective,
+        string renameDirective,
+        string removeDirective,
+        string lookupDirective,
+        string requireDirective,
         string selectionScalar,
         string selectionSetScalar,
         string typeNameScalar,
@@ -39,6 +44,11 @@ private FusionTypeNames(
         ReEncodeIdDirective = reEncodeIdDirective;
         TransportDirective = transportDirective;
         FusionDirective = fusionDirective;
+        InternalDirective = internalDirective;
+        RenameDirective = renameDirective;
+        RemoveDirective = removeDirective;
+        LookupDirective = lookupDirective;
+        RequireDirective = requireDirective;
         SelectionScalar = selectionScalar;
         SelectionSetScalar = selectionSetScalar;
         TypeNameScalar = typeNameScalar;
@@ -56,6 +66,12 @@ private FusionTypeNames(
         _fusionDirectives.Add(transportDirective);
         _fusionDirectives.Add(fusionDirective);
 
+        _fusionDirectives.Add(internalDirective);
+        _fusionDirectives.Add(renameDirective);
+        _fusionDirectives.Add(removeDirective);
+        _fusionDirectives.Add(lookupDirective);
+        _fusionDirectives.Add(requireDirective);
+
         _fusionTypes.Add(selectionScalar);
         _fusionTypes.Add(selectionSetScalar);
         _fusionTypes.Add(typeNameScalar);
@@ -110,6 +126,16 @@ private FusionTypeNames(
     /// </summary>
     public string FusionDirective { get; }
 
+    public string InternalDirective { get; }
+
+    public string RenameDirective { get; }
+
+    public string RemoveDirective { get; }
+
+    public string LookupDirective { get; }
+
+    public string RequireDirective { get; }
+
     /// <summary>
     /// Gets the name of the GraphQL selection scalar.
     /// </summary>
@@ -199,6 +225,11 @@ public static FusionTypeNames Create(string? prefix = null, bool prefixSelf = fa
                 prefixSelf
                     ? $"{prefix}_{FusionTypeBaseNames.FusionDirective}"
                     : FusionTypeBaseNames.FusionDirective,
+                FusionTypeBaseNames.InternalDirective,
+                FusionTypeBaseNames.RenameDirective,
+                FusionTypeBaseNames.RemoveDirective,
+                FusionTypeBaseNames.LookupDirective,
+                FusionTypeBaseNames.RequireDirective,
                 $"{prefix}_{FusionTypeBaseNames.Selection}",
                 $"{prefix}_{FusionTypeBaseNames.SelectionSet}",
                 $"{prefix}_{FusionTypeBaseNames.TypeName}",
@@ -218,6 +249,11 @@ public static FusionTypeNames Create(string? prefix = null, bool prefixSelf = fa
             FusionTypeBaseNames.ReEncodeIdDirective,
             FusionTypeBaseNames.TransportDirective,
             FusionTypeBaseNames.FusionDirective,
+            FusionTypeBaseNames.InternalDirective,
+            FusionTypeBaseNames.RenameDirective,
+            FusionTypeBaseNames.RemoveDirective,
+            FusionTypeBaseNames.LookupDirective,
+            FusionTypeBaseNames.RequireDirective,
             $"_{FusionTypeBaseNames.Selection}",
             $"_{FusionTypeBaseNames.SelectionSet}",
             $"_{FusionTypeBaseNames.TypeName}",

src/HotChocolate/Fusion/src/Composition/Extensions/ComplexTypeMergeExtensions.cs

@@ -15,6 +15,7 @@ public static OutputFieldDefinition CreateField(
         var target = new OutputFieldDefinition(source.Name);
         target.MergeDescriptionWith(source);
         target.MergeDeprecationWith(source);
+        target.MergeDirectivesWith(source, context);
 
         // Replace the type name of the field in the source with the corresponding type name
         // in the target schema.
@@ -33,6 +34,7 @@ public static OutputFieldDefinition CreateField(
             targetArgument.Type = sourceArgument.Type.ReplaceNameType(n => targetSchema.Types[n]);
 
             targetArgument.MergeDeprecationWith(sourceArgument);
+            targetArgument.MergeDirectivesWith(sourceArgument, context);
 
             target.Arguments.Add(targetArgument);
         }
@@ -126,6 +128,8 @@ public static void MergeField(
         // If the target field is not deprecated and the source field is deprecated, copy over the
         target.MergeDeprecationWith(source);
 
+        target.MergeDirectivesWith(source, context);
+
         foreach (var sourceArgument in source.Arguments)
         {
             var targetArgument = target.Arguments[sourceArgument.Name];
@@ -137,6 +141,8 @@ public static void MergeField(
             // If the target argument is not deprecated and the source argument is deprecated,
             targetArgument.MergeDeprecationWith(sourceArgument);
 
+            targetArgument.MergeDirectivesWith(sourceArgument, context);
+
             // If the target argument does not have a default value and the source argument does,
             if (sourceArgument.DefaultValue is not null &&
                 targetArgument.DefaultValue is null)

src/HotChocolate/Fusion/src/Composition/Extensions/InputObjectMergeExtensions.cs

@@ -20,6 +20,7 @@ public static InputFieldDefinition CreateField(
         var target = new InputFieldDefinition(source.Name, targetFieldType);
         target.MergeDescriptionWith(source);
         target.MergeDeprecationWith(source);
+        target.MergeDirectivesWith(source, context);
         target.DefaultValue = source.DefaultValue;
         return target;
     }
@@ -55,5 +56,6 @@ public static void MergeField(
 
         target.MergeDescriptionWith(source);
         target.MergeDeprecationWith(source);
+        target.MergeDirectivesWith(source, context);
     }
 }

src/HotChocolate/Fusion/src/Composition/Extensions/MergeExtensions.cs

@@ -165,6 +165,49 @@ internal static void MergeDescriptionWith(this INamedTypeDefinition target, INam
         }
     }
 
+    internal static void MergeDirectivesWith(
+        this IDirectivesProvider target,
+        IDirectivesProvider source,
+        CompositionContext context)
+    {
+        foreach (var directive in source.Directives)
+        {
+            if (context.FusionTypes.IsFusionDirective(directive.Name)
+                || BuiltIns.IsBuiltInDirective(directive.Name)
+                // @tag is handled separately
+                || directive.Name == "tag")
+            {
+                continue;
+            }
+
+            if (context.FusionGraph.DirectiveDefinitions.TryGetDirective(directive.Name, out var directiveDefinition)
+                && directiveDefinition.IsSpecDirective)
+            {
+                continue;
+            }
+
+            if (!target.Directives.ContainsName(directive.Name))
+            {
+                target.Directives.Add(directive);
+            }
+            else
+            {
+                if (directiveDefinition is not null && directiveDefinition.IsRepeatable)
+                {
+                    target.Directives.Add(directive);
+                }
+            }
+        }
+    }
+
+    internal static void MergeDescriptionWith(this DirectiveDefinition target, DirectiveDefinition source)
+    {
+        if (string.IsNullOrWhiteSpace(target.Description) && !string.IsNullOrWhiteSpace(source.Description))
+        {
+            target.Description = source.Description;
+        }
+    }
+
     internal static void MergeDescriptionWith(this EnumValue target, EnumValue source)
     {
         if (string.IsNullOrWhiteSpace(target.Description) && !string.IsNullOrWhiteSpace(source.Description))

src/HotChocolate/Fusion/src/Composition/FusionGraphComposer.cs

@@ -42,7 +42,7 @@ public FusionGraphComposer(
             [
                 new InterfaceTypeMergeHandler(), new UnionTypeMergeHandler(),
                 new InputObjectTypeMergeHandler(), new EnumTypeMergeHandler(),
-                new ScalarTypeMergeHandler(),
+                new ScalarTypeMergeHandler()
             ],
             fusionTypePrefix,
             fusionTypeSelf,
@@ -68,7 +68,9 @@ internal FusionGraphComposer(
                 .Use<MergeEntityMiddleware>()
                 .Use<EntityFieldDependencyMiddleware>()
                 .Use(() => new MergeTypeMiddleware(mergeHandlers))
+                .Use<RemoveDirectivesWithoutLocationMiddleware>()
                 .Use<MergeQueryAndMutationTypeMiddleware>()
+                .Use<MergeSchemaDefinitionMiddleware>()
                 .Use<MergeSubscriptionTypeMiddleware>()
                 .Use<NodeMiddleware>()
                 .Use<ApplyTagDirectiveMiddleware>()

src/HotChocolate/Fusion/src/Composition/FusionTypes.cs

@@ -1,3 +1,4 @@
+using System.Collections.Frozen;
 using HotChocolate.Fusion.Composition.Properties;
 using HotChocolate.Language;
 using HotChocolate.Skimmed;
@@ -13,6 +14,7 @@ public sealed class FusionTypes
 {
     private readonly SchemaDefinition _fusionGraph;
     private readonly bool _prefixSelf;
+    private readonly FusionTypeNames _fusionTypeNames;
 
     public FusionTypes(SchemaDefinition fusionGraph, string? prefix = null, bool prefixSelf = false)
     {
@@ -22,6 +24,7 @@ public FusionTypes(SchemaDefinition fusionGraph, string? prefix = null, bool pre
         }
 
         var names = FusionTypeNames.Create(prefix, prefixSelf);
+        _fusionTypeNames = names;
         _fusionGraph = fusionGraph;
         _prefixSelf = prefixSelf;
 
@@ -120,6 +123,8 @@ public FusionTypes(SchemaDefinition fusionGraph, string? prefix = null, bool pre
 
     public DirectiveDefinition Fusion { get; }
 
+    public bool IsFusionDirective(string directiveName) => _fusionTypeNames.IsFusionDirective(directiveName);
+
     private ScalarTypeDefinition RegisterScalarType(string name)
     {
         var scalarType = new ScalarTypeDefinition(name);

src/HotChocolate/Fusion/src/Composition/HotChocolate.Fusion.Composition.csproj

@@ -11,6 +11,7 @@
 
   <ItemGroup>
     <InternalsVisibleTo Include="HotChocolate.Fusion.Tests" />
+    <InternalsVisibleTo Include="HotChocolate.Fusion.Composition.Tests" />
   </ItemGroup>
 
   <ItemGroup>

src/HotChocolate/Fusion/src/Composition/LogEntryHelper.cs

@@ -86,6 +86,16 @@ public static LogEntry OutputFieldArgumentMismatch(
             coordinate: coordinate,
             member: field);
 
+    public static LogEntry DirectiveDefinitionArgumentMismatch(
+        SchemaCoordinate coordinate,
+        DirectiveDefinition directiveDefinition)
+        => new LogEntry(
+            LogEntryHelper_DirectiveDefinitionArgumentMismatch,
+            code: LogEntryCodes.DirectiveDefinitionArgumentMismatch,
+            severity: LogSeverity.Error,
+            coordinate: coordinate,
+            member: directiveDefinition);
+
     public static LogEntry OutputFieldArgumentSetMismatch(
         SchemaCoordinate coordinate,
         OutputFieldDefinition field,
@@ -193,5 +203,8 @@ static file class LogEntryCodes
     public const string FieldDependencyCannotBeResolved = "HF0008";
 
     public const string TypeNotDeclared = "HF0009";
+
     public const string RootNameMismatch = "HF0010";
+
+    public const string DirectiveDefinitionArgumentMismatch = "HF0011";
 }