[Fusion] Handle invalid @is usages more gracefully (#8740)

Author: tobias-tengler

src/HotChocolate/Fusion-vnext/src/Fusion.Utilities/Properties/FusionUtilitiesResources.Designer.cs

@@ -69,4 +69,7 @@
   <data name="SelectionSetValidator_UnionFieldInvalidSelections" xml:space="preserve">
     <value>The field '{0}' returns a union type and must only include inline fragment selections.</value>
   </data>
+  <data name="FieldSelectionMapValidator_InvalidFieldParentType" xml:space="preserve">
+    <value>Expected the parent type of field '{0}' to be a complex type but received '{1}'.</value>
+  </data>
 </root>

src/HotChocolate/Fusion-vnext/src/Fusion.Utilities/Properties/FusionUtilitiesResources.resx

@@ -122,7 +122,8 @@ protected override ISyntaxVisitorAction Enter(
         PathSegmentNode node,
         FieldSelectionMapValidatorContext context)
     {
-        if (context.OutputTypes.Peek().NullableType() is IComplexTypeDefinition complexType)
+        var outputType = context.OutputTypes.Peek();
+        if (outputType.NullableType() is IComplexTypeDefinition complexType)
         {
             if (!complexType.Fields.TryGetField(node.FieldName.Value, out var field))
             {
@@ -146,7 +147,7 @@ protected override ISyntaxVisitorAction Enter(
                     context.Errors.Add(
                         string.Format(
                             FieldSelectionMapValidator_FieldMissingTypeCondition,
-                            node.FieldName));
+                            node.FieldName.Value));
 
                     return Break;
                 }
@@ -201,6 +202,16 @@ protected override ISyntaxVisitorAction Enter(
                 context.TerminalTypes.Push(field.Type);
             }
         }
+        else
+        {
+            context.Errors.Add(
+                string.Format(
+                    FieldSelectionMapValidator_InvalidFieldParentType,
+                    node.FieldName.Value,
+                    outputType));
+
+            return Break;
+        }
 
         if (node.TypeName is { } typeName)
         {

src/HotChocolate/Fusion-vnext/src/Fusion.Utilities/Validators/FieldSelectionMapValidator.cs

@@ -73,6 +73,27 @@ type Person {
                     }
                     """
                 ]
+            },
+            {
+                [
+                    """
+                    # Schema A
+                    type Query {
+                        personByName(name: String! @is(field: "name")): Person @lookup
+                    }
+
+                    type Person {
+                        id: ID!
+                    }
+                    """,
+                    """
+                    # Schema B
+                    type Person {
+                        id: ID!
+                        name: String!
+                    }
+                    """
+                ]
             }
         };
     }
@@ -101,6 +122,86 @@ type Person {
                     "The @is directive on argument 'Query.personById(id:)' in schema 'A' "
                     + "specifies an invalid field selection against the composed schema."
                 ]
+            },
+            // Type of argument does not match field type.
+            {
+                [
+                    """
+                    # Schema A
+                    type Query {
+                        personById(id: Int! @is(field: "id")): Person @lookup
+                    }
+
+                    type Person {
+                        id: ID!
+                        name: String
+                    }
+                    """
+                ],
+                [
+                    "The @is directive on argument 'Query.personById(id:)' in schema 'A' "
+                    + "specifies an invalid field selection against the composed schema."
+                ]
+            },
+            // List output type, Singular input type.
+            {
+                [
+                    """
+                    # Schema A
+                    type Query {
+                        personsById(id: ID! @is(field: "id")): [Person!]! @lookup
+                    }
+
+                    type Person {
+                        id: ID!
+                        name: String
+                    }
+                    """
+                ],
+                [
+                    "The @is directive on argument 'Query.personsById(id:)' in schema 'A' "
+                    + "specifies an invalid field selection against the composed schema."
+                ]
+            },
+            // Singular output type, List input type.
+            {
+                [
+                    """
+                    # Schema A
+                    type Query {
+                        personByIds(ids: [ID!]! @is(field: "id")): Person! @lookup
+                    }
+
+                    type Person {
+                        id: ID!
+                        name: String
+                    }
+                    """
+                ],
+                [
+                    "The @is directive on argument 'Query.personByIds(ids:)' in schema 'A' "
+                    + "specifies an invalid field selection against the composed schema."
+                ]
+            },
+            // List output type, List input type (valid for Fusion v1 batch lookups).
+            {
+                [
+                    """
+                    # Schema A
+                    type Query {
+                        personsByIds(ids: [ID!]! @is(field: "id")): [Person!]! @lookup
+                    }
+
+                    type Person {
+                        id: ID!
+                        name: String
+                    }
+                    """
+                ],
+                [
+                    "The @is directive on argument 'Query.personsByIds(ids:)' in schema 'A' "
+                    + "specifies an invalid field selection against the composed schema."
+                ]
             }
         };
     }