Fix Several Source Generator Issues (#8856)

Author: michaelstaib

.gitignore

@@ -326,3 +326,4 @@ conferences.db-wal
 packages.lock.json
 
 Directory.Build.props.user
+.generated/

src/HotChocolate/ApolloFederation/src/ApolloFederation/FederationTypeInterceptor.cs

@@ -4,6 +4,7 @@
 using HotChocolate.ApolloFederation.Resolvers;
 using HotChocolate.ApolloFederation.Types;
 using HotChocolate.Configuration;
+using HotChocolate.Internal;
 using HotChocolate.Language;
 using HotChocolate.Resolvers;
 using HotChocolate.Types.Descriptors;

src/HotChocolate/ApolloFederation/src/ApolloFederation/Resolvers/ReferenceResolverAttribute.cs

@@ -24,11 +24,11 @@ public class ReferenceResolverAttribute : DescriptorAttribute
     protected internal override void TryConfigure(
         IDescriptorContext context,
         IDescriptor descriptor,
-        ICustomAttributeProvider element)
+        ICustomAttributeProvider? attributeProvider)
     {
         if (descriptor is IObjectTypeDescriptor objectTypeDescriptor)
         {
-            switch (element)
+            switch (attributeProvider)
             {
                 case Type type:
                     OnConfigure(objectTypeDescriptor, type);
@@ -42,7 +42,7 @@ protected internal override void TryConfigure(
 
         if (descriptor is IInterfaceTypeDescriptor interfaceTypeDescriptor)
         {
-            switch (element)
+            switch (attributeProvider)
             {
                 case Type type:
                     OnConfigure(interfaceTypeDescriptor, type);

src/HotChocolate/ApolloFederation/src/ApolloFederation/ThrowHelper.cs

@@ -148,25 +148,25 @@ public static SchemaException Key_FieldSet_ResolvableMustBeConsistent(
     /// <see cref="string.Empty"/>.
     /// </summary>
     public static SchemaException Provides_FieldSet_CannotBeEmpty(
-        MemberInfo member) =>
+        string fieldName) =>
         new SchemaException(
             SchemaErrorBuilder.New()
                 .SetMessage(ThrowHelper_Provides_FieldSet_CannotBeEmpty)
                 // .SetCode(ErrorCodes.ApolloFederation.ProvidesFieldSetNullOrEmpty)
-                .SetExtension(nameof(member), member)
+                .SetExtension(nameof(fieldName), fieldName)
                 .Build());
 
     /// <summary>
     /// The requires attribute is used and the fieldset is set to <c>null</c> or
     /// <see cref="string.Empty"/>.
     /// </summary>
     public static SchemaException Requires_FieldSet_CannotBeEmpty(
-        MemberInfo member) =>
+        string fieldName) =>
         new SchemaException(
             SchemaErrorBuilder.New()
                 .SetMessage(ThrowHelper_Requires_FieldSet_CannotBeEmpty)
                 // .SetCode(ErrorCodes.ApolloFederation.RequiresFieldSetNullOrEmpty)
-                .SetExtension(nameof(member), member)
+                .SetExtension(nameof(fieldName), fieldName)
                 .Build());
 
     /// <summary>

src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/Directives/AuthenticatedAttribute.cs

@@ -38,7 +38,7 @@ public sealed class AuthenticatedAttribute : DescriptorAttribute
     protected internal override void TryConfigure(
         IDescriptorContext context,
         IDescriptor descriptor,
-        ICustomAttributeProvider element)
+        ICustomAttributeProvider? attributeProvider)
     {
         switch (descriptor)
         {

src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/Directives/ExtendServiceTypeAttribute.cs

@@ -26,6 +26,6 @@ public sealed class ExtendServiceTypeAttribute : ObjectTypeDescriptorAttribute
     protected override void OnConfigure(
         IDescriptorContext context,
         IObjectTypeDescriptor descriptor,
-        Type type)
+        Type? type)
         => descriptor.ExtendServiceType();
 }

src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/Directives/ExternalAttribute.cs

@@ -39,7 +39,7 @@ public sealed class ExternalAttribute : DescriptorAttribute
     protected internal override void TryConfigure(
         IDescriptorContext context,
         IDescriptor descriptor,
-        ICustomAttributeProvider element)
+        ICustomAttributeProvider? attributeProvider)
     {
         switch (descriptor)
         {

src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/Directives/InaccessibleAttribute.cs

@@ -48,7 +48,7 @@ public sealed class InaccessibleAttribute : DescriptorAttribute
     protected internal override void TryConfigure(
         IDescriptorContext context,
         IDescriptor descriptor,
-        ICustomAttributeProvider element)
+        ICustomAttributeProvider? attributeProvider)
     {
         switch (descriptor)
         {

src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/Directives/InterfaceObjectAttribute.cs

@@ -24,6 +24,6 @@ public sealed class InterfaceObjectAttribute : ObjectTypeDescriptorAttribute
     protected override void OnConfigure(
         IDescriptorContext context,
         IObjectTypeDescriptor descriptor,
-        Type type)
+        Type? type)
         => descriptor.InterfaceObject();
 }

src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/Directives/KeyAttribute.cs

@@ -79,9 +79,9 @@ public KeyAttribute(string fieldSet, bool resolvable = true)
     protected internal override void TryConfigure(
         IDescriptorContext context,
         IDescriptor descriptor,
-        ICustomAttributeProvider element)
+        ICustomAttributeProvider? attributeProvider)
     {
-        switch (element)
+        switch (attributeProvider)
         {
             case Type type:
                 ConfigureType(type, descriptor);