Skip to content

Add analyzers #8072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glen-84 opened this issue Feb 26, 2025 · 1 comment
Open

Add analyzers #8072

glen-84 opened this issue Feb 26, 2025 · 1 comment

Comments

@glen-84
Copy link
Collaborator

glen-84 commented Feb 26, 2025

Product

Hot Chocolate

Is your feature request related to a problem?

Developers using the platform may not be following best practices.

The solution you'd like

Add analyzers such as:

  • Don't use .With(queryContext) and .Select together.
  • Node resolver id argument doesn't need [ID].
  • Don't need [Service].
  • Somehow warn when the user doesn't have the HC.EF package installed.
  • Encourage modern APIs (f.e. ObjectType<T>).
  • Specify requirements when using [Parent] and QueryContext.
  • Call AddFiltering when using [UseFiltering].
@PascalSenn
Copy link
Member

PascalSenn commented Feb 26, 2025

  • Order of middlewares
  • Not providing an IReadOnlyList<T> keys as the first argument of a dataloader

@michaelstaib michaelstaib added this to the HC-15.x.x milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants