Skip to content

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Oct 28, 2024

Summary of the changes (Less than 80 chars)

  • Added opt-in features.

Closes #7720


❓ Questions:

  • Please check the schema error definitions in ErrorHelper.cs.
    • Should I be setting an error code or specified by?
  • I'm returning one error for each application of the directive, is that correct?
    • In theory, we could be including information about the directive syntax position, arguments, etc.

📓 Spec notes:

  • Should we explicitly disallow empty and whitespace-only feature strings? *
  • Should we disallow whitespace or other characters within feature names, or leave it completely open? *
  • I've used includeOptIn instead of includeRequiresOptIn for introspection, as it seemed more clear, WDYT?

* stability strings as well.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.39%. Comparing base (d1e6ac3) to head (f7eaab4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7652      +/-   ##
==========================================
+ Coverage   74.32%   74.39%   +0.06%     
==========================================
  Files        2880     2891      +11     
  Lines      150189   150616     +427     
  Branches    17468    17515      +47     
==========================================
+ Hits       111629   112050     +421     
  Misses      32745    32745              
- Partials     5815     5821       +6     
Flag Coverage Δ
unittests 74.39% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 marked this pull request as ready for review October 30, 2024 09:13
@michaelstaib michaelstaib added this to the HC-14.2.0 milestone Nov 4, 2024
@glen-84 glen-84 added the 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. label Nov 14, 2024
@michaelstaib michaelstaib modified the milestones: HC-14.2.0, HC-14.4.0 Dec 3, 2024
@michaelstaib michaelstaib modified the milestones: HC-14.4.0, HC-14.5.0 Dec 17, 2024
@michaelstaib michaelstaib modified the milestones: HC-14.5.0, HC-14.6.0 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ hot chocolate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement @requiresOptIn

2 participants