Skip to content

Improve performance of XML doc inference #8794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Improve performance of XML doc inference #8794

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
945a503
Optimized XmlDocumentationFileResolver-cache
N-Olbert Oct 7, 2025
d0232ef
Switch to XPathDocument (core changes)
N-Olbert Oct 7, 2025
02e4840
Green tests + Benchmark + Small improvements
N-Olbert Oct 8, 2025
c138420
Back to default, huge alloc optimizations
N-Olbert Oct 9, 2025
8782e8c
Further (agressive) optimizations.
N-Olbert Oct 9, 2025
def4a6d
Fix Inhertidoc again, ensure threadsafety
N-Olbert Oct 9, 2025
3bd95dc
Ensure thread-safety.
N-Olbert Oct 10, 2025
d3833a9
Skip bench
N-Olbert Oct 10, 2025
143eb2f
Merge branch 'main' into 8775
michaelstaib Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/HotChocolate/Core/src/Types/Types/Descriptors/Conventions/DescriptorContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public INamingConventions Naming
_naming ??= GetConventionOrDefault<INamingConventions>(() => Options.UseXmlDocumentation
? new DefaultNamingConventions(
new XmlDocumentationProvider(
new XmlDocumentationFileResolver(
new XmlDocumentationResolver(
Options.ResolveXmlDocumentationFileName),
_serviceHelper.GetStringBuilderPool()))
: new DefaultNamingConventions(
Expand Down
9 changes: 4 additions & 5 deletions ...ventions/IXmlDocumentationFileResolver.cs → .../Conventions/IXmlDocumentationResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,11 @@ namespace HotChocolate.Types.Descriptors;
/// <summary>
/// Resolves an XML documentation file from an assembly.
/// </summary>
public interface IXmlDocumentationFileResolver
public interface IXmlDocumentationResolver
{
/// <summary>
/// Trues to resolve an XML documentation file from the given assembly..
/// Trues to resolve an XML documentation element from the given assembly..
/// </summary>
bool TryGetXmlDocument(
Assembly assembly,
[NotNullWhen(true)] out XDocument? document);
bool TryGetXmlDocument(Assembly assembly,
[NotNullWhen(true)] out IReadOnlyDictionary<string, XElement>? memberLookup);
}
Loading