[Fusion] Improve OperationCompiler performance #8823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes OperationCompiler performance by removing the InlineFragmentOperationRewriter and refactoring method signatures to work directly with operations instead of full documents.
Key changes:
- Removes InlineFragmentOperationRewriter from OperationCompiler since documents are already rewritten when compiling
- Changes DocumentRewriter.RewriteDocument to return OperationDefinitionNode directly via RewriteOperation
- Adds benchmarks for OperationCompiler, DocumentRewriter, and OperationPlanner
Reviewed Changes
Copilot reviewed 26 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| DocumentRewriter.cs | Changed method signature to return OperationDefinitionNode directly and improved field comparison logic |
| OperationCompiler.cs | Removed InlineFragmentOperationRewriter dependency and redundant document rewriting |
| OperationPlanner.cs | Added TryCreatePlan method and improved selection inlining with deduplication |
| Various test files | Updated method calls to use new RewriteOperation signature |
| Benchmark files | Added new benchmark classes for performance testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Planning/OperationPlanner.cs
Show resolved
Hide resolved
src/HotChocolate/Fusion-vnext/src/Fusion.Utilities/Rewriters/DocumentRewriter.cs
Show resolved
Hide resolved
Comment on lines
1392
to
1407
| if (seenSelections.Add(fieldWithDirective)) | ||
| { | ||
| var insertIndex = newSelections.Count; | ||
| var fieldName = field.Name.Value; | ||
|
|
||
| for (var i = newSelections.Count - 1; i >= 0; i--) | ||
| { | ||
| if (newSelections[i] is FieldNode existingField | ||
| && existingField.Name.Value.Equals(fieldName, StringComparison.Ordinal)) | ||
| { | ||
| insertIndex = i + 1; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| newSelections.Insert(insertIndex, fieldWithDirective); |
There was a problem hiding this comment.
The reverse loop to find insertion index could be inefficient for large selection sets. Consider maintaining a dictionary mapping field names to their last index positions to avoid O(n) lookups for each insertion.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OperationCompiler,DocumentRewriterand the plan portion ofOperationPlanner.DocumentRewriterfrom OperationCompiler for improved performanceDocumentRewriteris basically just sorting the inserted requirements at that point...