Skip to content

Fix #6723 error registration with mutation conventions in ITypeModule#9257

Open
michaelstaib wants to merge 1 commit intomainfrom
mst/issue-6723
Open

Fix #6723 error registration with mutation conventions in ITypeModule#9257
michaelstaib wants to merge 1 commit intomainfrom
mst/issue-6723

Conversation

@michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Feb 27, 2026

Fixes #6723

Summary

  • ensure .UseMutationConvention(...) eagerly enables the mutation/error schema features in the descriptor context
  • add a regression test that reproduces the ITypeModule scenario from Cannot add Errors with MutationConventions via ITypeModule #6723 (UseMutationConvention(...).Error<T>()) and validates generated payload/error types

Test Commands

  • dotnet test src/HotChocolate/Core/test/Execution.Tests/HotChocolate.Execution.Tests.csproj --filter "FullyQualifiedName~Issue6723Tests"
  • dotnet test src/HotChocolate/Core/test/Execution.Tests/HotChocolate.Execution.Tests.csproj --filter "FullyQualifiedName~TypeModuleTests|FullyQualifiedName~Issue6723Tests"

Results

  • Passed on net8.0, net9.0, and net10.0.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

Fusion Gateway Performance Results

Simple Composite Query

Req/s Err%
Constant 2 (50 VUs) 3279.11 0.00%
Ramping 2 (0-500-0 VUs) 3847.56 0.00%
Response Times
Min Med Avg P90 P95 Max
Constant 2 1.16ms 12.27ms 14.97ms 24.47ms 33.82ms 259.70ms
Ramping 2 1.26ms 51.30ms 56.96ms 100.20ms 142.43ms 288.10ms

Deep Recursion Query

Req/s Err%
Constant 2 (50 VUs) 755.45 0.00%
Ramping 2 (0-500-0 VUs) 933.81 0.00%
Response Times
Min Med Avg P90 P95 Max
Constant 2 9.09ms 57.69ms 63.78ms 83.01ms 100.78ms 716.14ms
Ramping 2 2.93ms 201.26ms 221.49ms 456.13ms 517.81ms 995.07ms

Variable Batching Throughput

Req/s Err%
Constant 2 (50 VUs) 6091.15 0.00%
Ramping 2 (0-500-0 VUs) 5158.55 0.00%
Response Times
Min Med Avg P90 P95 Max
Constant 2 0.15ms 7.69ms 8.11ms 13.43ms 16.39ms 55.32ms
Ramping 2 0.19ms 40.62ms 44.55ms 82.19ms 107.73ms 234.47ms

Runner 2 = benchmarking-2

Run 22494084114 • Commit 3225a3f • Fri, 27 Feb 2026 16:23:57 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot add Errors with MutationConventions via ITypeModule

1 participant