Open
Conversation
github-actions
bot
added
📚 documentation
Contributor
Fusion Gateway Performance Results
Simple Composite Query
Response Times
Deep Recursion Query
Response Times
Variable Batching Throughput
Response Times
Runner 1 = benchmarking-1Run 22730129934 • Commit d20e7df • Fri, 06 Mar 2026 18:12:46 GMT |
tobias-tengler
force-pushed
the
tte/align-with-otel-spec
branch
from
e170a0a to
67734b1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns HotChocolate (and Fusion) diagnostics instrumentation with OTEL/GraphQL semantic conventions by introducing a shared Diagnostics.Core layer, refactoring instrumentation to span-based helpers, and updating emitted tags/activities accordingly.
Changes:
- Introduces
HotChocolate.Diagnostics.Corewith shared span primitives, options base types, and activity enrichment helpers. - Refactors server/query instrumentation to emit updated activity names/tags (e.g.,
graphql.processing.type,graphql.http.kind,graphql.error.*) and updates snapshots/tests. - Adjusts public-facing APIs related to path/document access and instrumentation options to match the new conventions.
Reviewed changes
Copilot reviewed 182 out of 196 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/ServerInstrumentationTests.Parsing_Error_When_Rename_Root_Is_Activated.snap | Updates expected HTTP parsing error span naming/tags to new semantic conventions. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/ServerInstrumentationTests.Http_Post_Parser_Error.snap | Updates expected parser error activity tags and error event fields. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/ServerInstrumentationTests.Http_Post_Add_Query_To_Http_Activity.snap | Removes outdated snapshot after instrumentation refactor. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/ServerInstrumentationTests.Http_Get_SDL_Download.snap | Adds graphql.http.kind tag to GET SDL activity snapshot. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.ValidationError_UnknownField_ReportsErrorStatus.snap | Adds new snapshot for validation error reporting with graphql.error.* fields. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.Track_Events_Of_A_Simple_Query_With_Node_Scopes.snap | Removes outdated snapshot after activity model changes. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.Track_Events_Of_A_Simple_Query_Detailed.snap | Removes outdated snapshot after activity model changes. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.Track_Events_Of_A_Simple_Query_Default.snap | Updates default-scope activity snapshots to new span names/tags. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.PersistedOperation_LoadsFromStorage_DefaultScopes.snap | Adds new snapshot for persisted operations under new conventions. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.ParsingError_InvalidGraphQLDocument_ReportsErrorStatus.snap | Adds snapshot for parsing errors at operation level. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.Ensure_That_The_Validation_Activity_Has_An_Error_Status.snap | Updates validation error snapshot to graphql.error.* event tags. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.Ensure_Operation_Name_Is_Used_As_Request_Name.snap | Removes outdated snapshot due to request span renaming. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.DefaultScopes_ExcludesExecuteRequestAndParseDocumentSpans.snap | Adds snapshot for default scopes excluding certain spans. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.CustomScopes_OnlyValidateAndPlan_LimitsSpans.snap | Adds snapshot verifying custom scope limiting for validate/plan. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.Create_Operation_Display_Name_With_4_Field.snap | Removes outdated display-name snapshot tied to old root-renaming behavior. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.Create_Operation_Display_Name_With_3_Field.snap | Removes outdated display-name snapshot tied to old root-renaming behavior. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.Create_Operation_Display_Name_With_1_Field_And_Op.snap | Removes outdated display-name snapshot tied to old root-renaming behavior. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.Create_Operation_Display_Name_With_1_Field.snap | Removes outdated display-name snapshot tied to old root-renaming behavior. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.Cause_A_Resolver_Error_That_Deletes_The_Whole_Result_Deep.snap | Removes outdated snapshot after resolver/error span changes. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/snapshots/QueryInstrumentationTests.AllScopes_IncludesAllSpans.snap | Adds snapshot verifying full-span emission under new model. |
| src/HotChocolate/Fusion-vnext/test/Fusion.Diagnostics.Tests/HotChocolate.Fusion.Diagnostics.Tests.csproj | Adds reference to Diagnostics.Core for shared span primitives in tests. |
| src/HotChocolate/Fusion-vnext/test/Fusion.AspNetCore.Tests/snapshots/VariableCoercionTests.InputObject_Invalid_Field.yaml | Updates variable error extension value format in snapshot. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Utilities/HotChocolate.Fusion.Utilities.csproj | Adds execution abstractions reference used by updated utilities. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Utilities/Extensions/FusionDocumentNodeExtensions.cs | Replaces placeholder exceptions with GraphQLException built via ErrorBuilder. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Diagnostics/IFusionExecutionDiagnosticEvents.cs | Narrows parameter type to OperationBatchExecutionNode for batch execution events. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Diagnostics/FusionExecutionDiagnosticEventListener.cs | Updates signature to match interface change. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Execution/Diagnostics/AggregateFusionExecutionDiagnosticEvents.cs | Updates signature to match interface change and aggregation logic. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Spans/PlanOperationSpan.cs | Adds new span type for planning with semantic convention tags. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Spans/ExecuteRequestSpan.cs | Adds Fusion-specific execute-request span implementing shared base. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Spans/ExecutePlanNodeSpan.cs | Adds plan-node execution span with step tags (id/kind/plan/source). |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Scopes/ValidateDocumentScope.cs | Removes legacy scope implementation in favor of span model. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Scopes/RequestScopeBase.cs | Removes legacy scope base. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Scopes/PlanOperationScope.cs | Removes legacy scope implementation in favor of span model. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Scopes/ParseDocumentScope.cs | Removes legacy scope implementation in favor of span model. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Scopes/NodeScopeBase.cs | Removes legacy node scope base. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Scopes/ExecuteRequestScope.cs | Removes legacy request scope implementation in favor of span model. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Scopes/ExecuteOperationScope.cs | Removes legacy operation scope implementation in favor of span model. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Scopes/ExecuteOperationNodeScope.cs | Removes legacy operation-node scope implementation in favor of span model. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Scopes/ExecuteOperationBatchNodeScope.cs | Removes legacy batch-node scope implementation in favor of span model. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Scopes/ExecuteNodeFieldNodeScope.cs | Removes legacy node-field scope implementation in favor of span model. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Scopes/ExecuteIntrospectionNodeScope.cs | Removes legacy introspection scope implementation in favor of span model. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Scopes/CoerceVariablesScope.cs | Removes legacy coercion scope implementation in favor of span model. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/RequestDetails.cs | Removes duplicated RequestDetails enum (moved to Diagnostics.Core). |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Listeners/FusionActivityServerDiagnosticListener.cs | Adds new server listener using span types + HttpContext features storage. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Listeners/ActivityServerDiagnosticListener.cs | Removes legacy activity-based server listener. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/InstrumentationOptions.cs | Derives options from shared base and updates scope flags names. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/HotChocolateFusionActivitySource.cs | Fixes activity source name/version lookup to updated listener type. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/HotChocolate.Fusion.Diagnostics.csproj | Adds Diagnostics.Core project reference. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/FusionActivityScopes.cs | Renames ExecuteNodes to ExecutePlanNodes across scope flags. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/Extensions/DiagnosticsFusionGatewayBuilderExtensions.cs | Switches to new activity-based listeners and simplified enricher construction. |
| src/HotChocolate/Fusion-vnext/src/Fusion.Diagnostics/ContextKeys.cs | Removes legacy HttpContext item keys (now using context.Features). |
| src/HotChocolate/Fusion-vnext/src/Fusion.Aspire/SchemaComposition.cs | Avoids Path name collision by aliasing System.IO.Path. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/ServerInstrumentationTests.Validation_error_when_rename_root_is_activated.snap | Removes outdated snapshot tied to old root-rename behavior. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/ServerInstrumentationTests.Validation_Error_When_Rename_Root_Is_Activated.snap | Adds updated snapshot with graphql.http.kind and graphql.error.*. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/ServerInstrumentationTests.Parsing_Error_When_Rename_Root_Is_Activated.snap | Updates parsing error snapshot to new activity naming/tagging. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/ServerInstrumentationTests.Http_Post_variables_are_not_automatically_added_to_activities.snap | Removes outdated snapshot due to request-details changes. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/ServerInstrumentationTests.Http_Post_add_variables_to_http_activity.snap | Removes outdated snapshot due to request-details changes. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/ServerInstrumentationTests.Http_Post_add_query_to_http_activity.snap | Removes outdated snapshot due to request-details changes. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/ServerInstrumentationTests.Http_Post_SingleRequest_GetHeroName_Default.snap | Updates HTTP POST single-request snapshot for new root naming/tags. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/ServerInstrumentationTests.Http_Post_Parser_Error.snap | Updates HTTP parser error snapshot to graphql.error.*. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/ServerInstrumentationTests.Http_Get_SDL_Download.snap | Updates GET SDL snapshot with graphql.http.kind. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.VariableCoercion_WithAllScopes_RecordsCoercionSpan.snap | Adds snapshot for variable coercion span under new conventions. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.ValidationError_UnknownField_ReportsErrorStatus.snap | Adds snapshot for validation errors using graphql.error.*. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Track_events_of_a_simple_query_detailed.snap | Removes outdated snapshot (old activity model). |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Track_data_loader_events_with_keys.snap | Removes outdated snapshot (old dataloader activity model). |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Track_data_loader_events.snap | Removes outdated snapshot (old dataloader activity model). |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Track_Events_Of_A_Simple_Query_Default.snap | Adds new default-scope query snapshot under new conventions. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.ResolverError_DeepInTree_MarksNestedFieldAsError.snap | Adds snapshot ensuring nested resolver error marks spans as error. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.ResolverError_AtRootLevel_MarksOperationAsError.snap | Adds snapshot ensuring operation span marks error on root resolver failure. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.PersistedOperation_LoadsFromStorage_DefaultScopes.snap | Adds snapshot verifying persisted-operation tags. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.ParsingError_InvalidGraphQLDocument_ReportsErrorStatus.snap | Adds snapshot for invalid document parsing error propagation. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Ensure_that_the_validation_activity_has_an_error_status.snap | Removes outdated snapshot (old status/tag scheme). |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Ensure_operation_name_is_used_as_request_name.snap | Removes outdated snapshot (old request span naming). |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Ensure_That_The_Validation_Activity_Has_An_Error_Status.snap | Adds updated validation-error snapshot using new conventions. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.DefaultScopes_ExcludesExecuteRequestAndParseDocumentSpans.snap | Updates default scope expectations for validate/plan/resolve spans. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.CustomScopes_OnlyValidateAndCompile_LimitsSpans.snap | Adds snapshot verifying custom scopes under new span names. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Create_operation_display_name_with_3_field.snap | Removes outdated snapshot (old resolver span conventions). |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Create_operation_display_name_with_1_field_and_op.snap | Removes outdated snapshot (old resolver span conventions). |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Create_operation_display_name_with_1_field.snap | Removes outdated snapshot (old resolver span conventions). |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.ComplexityAnalysis_Enabled_RecordsCostInSpan.snap | Adds snapshot verifying complexity cost tags. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Cause_a_resolver_error_that_deletes_the_whole_result_deep.snap | Removes outdated snapshot (old activity model). |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Cause_a_resolver_error_that_deletes_the_whole_result.snap | Removes outdated snapshot (old activity model). |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Cause_A_Resolver_Error_That_Deletes_The_Whole_Result.snap | Adds updated snapshot for resolver error behavior under new conventions. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Allow_document_to_be_captured.snap | Removes outdated snapshot (old request details model). |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.Allow_Document_To_Be_Captured.snap | Adds updated snapshot verifying document capture under new request span. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/QueryInstrumentationTests.AllScopes_IncludesExecuteRequestAndParseDocumentSpans.snap | Adds snapshot for all-scopes behavior under new span model. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/ActivityDataLoaderDiagnosticListenerTests.Run_Batch_Dispatch_Coordinator_Tracks_Dispatch_Events.snap | Adds snapshot coverage for new dataloader dispatch span + events. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/snapshots/ActivityDataLoaderDiagnosticListenerTests.Run_Batch_Dispatch_Coordinator_Emits_Activity.snap | Adds snapshot coverage for new dataloader dispatch span. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/HotChocolate.Diagnostics.Tests.csproj | Adds CostAnalysis project reference for complexity instrumentation tests. |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/ActivityTestHelper.cs | Serializes TagObjects to support non-string tags (arrays/objects). |
| src/HotChocolate/Diagnostics/test/Diagnostics.Tests/ActivityDataLoaderDiagnosticListenerTests.cs | Adds tests for dataloader dispatch activity and dispatch events. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Spans/ResolveFieldSpan.cs | Adds span-based resolver-field instrumentation using semantic conventions. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Spans/ExecuteRequestSpan.cs | Adds request span implementation on top of shared ExecuteRequest base span. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Spans/DataLoaderDispatchSpan.cs | Adds dataloader dispatch span with processing type tag. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Spans/DataLoaderBatchSpan.cs | Adds dataloader batch span (with optional keys tagging). |
| src/HotChocolate/Diagnostics/src/Diagnostics/Spans/CompileOperationSpan.cs | Adds planning span (renamed from compile) aligned with semantic conventions. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ValidateDocumentScope.cs | Removes legacy scope implementation in favor of span model. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/RequestScopeBase.cs | Removes legacy scope base. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ParseDocumentScope.cs | Removes legacy parsing scope. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ExecuteRequestScope.cs | Removes legacy request scope. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/ExecuteOperationScope.cs | Removes legacy operation scope. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/DataLoaderBatchScope.cs | Removes legacy dataloader batch scope. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/CompileOperationScope.cs | Removes legacy compile scope. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/CoerceVariablesScope.cs | Removes legacy coercion scope. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Scopes/AnalyzeOperationComplexityScope.cs | Removes legacy complexity analysis scope. |
| src/HotChocolate/Diagnostics/src/Diagnostics/RequestDetails.cs | Removes duplicated RequestDetails enum (moved to Diagnostics.Core). |
| src/HotChocolate/Diagnostics/src/Diagnostics/Listeners/ActivityDataLoaderDiagnosticListener.cs | Refactors listener to create/return spans and enrich errors/events. |
| src/HotChocolate/Diagnostics/src/Diagnostics/InstrumentationOptions.cs | Derives options from shared base (moving request-details config). |
| src/HotChocolate/Diagnostics/src/Diagnostics/HotChocolate.Diagnostics.csproj | Adds Diagnostics.Core project reference. |
| src/HotChocolate/Diagnostics/src/Diagnostics/Extensions/DiagnosticsRequestExecutorBuilderExtensions.cs | Updates internal enricher construction for new base types. |
| src/HotChocolate/Diagnostics/src/Diagnostics/ContextKeys.cs | Removes legacy context keys; instrumentation now uses features/spans. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/VariableCoercionSpan.cs | Adds shared span for variable coercion with semantic tags. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/ValidationSpan.cs | Adds shared validation span aligned to semantic conventions. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/SpanBase.cs | Introduces shared base span type with completion hook. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/ParsingSpan.cs | Adds shared parsing span with document info enrichment. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/Http/ParseHttpRequestSpan.cs | Adds shared HTTP parsing span with GraphQL error event recording. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/Http/FormatHttpResponseSpan.cs | Adds shared HTTP response formatting span. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/ExecuteRequestSpanBase.cs | Adds shared request span base that sets name/tags/status + optional doc body. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/ExecuteOperationSpan.cs | Adds shared execute-operation span with semantic tags/status. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/AnalyzeOperationComplexitySpan.cs | Adds shared complexity analysis span and cost tagging. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/RequestDetails.cs | Reintroduces RequestDetails in shared core with renamed members. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/InstrumentationOptionsBase.cs | Adds shared options base for include-document and request-details flags. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/HotChocolate.Diagnostics.Core.csproj | Adds new core diagnostics project used by Diagnostics and Fusion.Diagnostics. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/Extensions/ActivityExtensions.cs | Adds shared activity helpers for GraphQL errors, operation/doc tags, and exceptions. |
| src/HotChocolate/Diagnostics/src/Diagnostics.Core/ActivityEnricherBase.cs | Adds shared enricher base API for both server and execution spans. |
| src/HotChocolate/Diagnostics/HotChocolate.Diagnostics.slnx | Adds Diagnostics.Core project to solution. |
| src/HotChocolate/CostAnalysis/src/CostAnalysis/CostAnalyzerMiddleware.cs | Switches to TryGetDocument for document retrieval. |
| src/HotChocolate/Core/test/Types.Tests/Types/snapshots/DirectiveTypeTests.Directive_ValidateArgs_Overflow.snap | Updates printed path formatting in snapshot. |
| src/HotChocolate/Core/test/Types.Tests/Types/snapshots/DirectiveTypeTests.Directive_ValidateArgs_NonNullArgIsNull.snap | Updates printed path formatting in snapshot. |
| src/HotChocolate/Core/test/Types.Tests/Types/snapshots/DirectiveTypeTests.Directive_ValidateArgs_InvalidArg.snap | Updates printed path formatting in snapshot. |
| src/HotChocolate/Core/test/Types.Tests/Types/snapshots/DirectiveTypeTests.Directive_ValidateArgs_ArgMissing.snap | Updates printed path formatting in snapshot. |
| src/HotChocolate/Core/test/Execution.Tests/ArgumentNonNullValidatorTests.cs | Updates expected path string format in assertion. |
| src/HotChocolate/Core/test/Execution.Abstractions.Tests/PathTests.cs | Updates Path.ToString() expectations and adds Path.Print() tests. |
| src/HotChocolate/Core/test/Execution.Abstractions.Tests/ErrorTests.cs | Updates printed error path expectation. |
| src/HotChocolate/Core/test/Execution.Abstractions.Tests/ErrorBuilderTests.cs | Updates expected path print string. |
| src/HotChocolate/Core/src/Types/Execution/Instrumentation/IExecutionDiagnosticEvents.cs | Removes several diagnostic hooks (stream/deferred/batch dispatch/extra resolver error variant). |
| src/HotChocolate/Core/src/Types/Execution/Instrumentation/AggregateExecutionDiagnosticEvents.cs | Removes implementations corresponding to removed interface members. |
| src/HotChocolate/Core/src/Execution.Abstractions/Path.cs | Changes Path.Print() formatting to dot notation and root to empty string. |
| src/HotChocolate/Core/src/Execution.Abstractions/Execution/Extensions/RequestContextExtensions.cs | Renames TryGetOperationDocument to TryGetDocument. |
| src/HotChocolate/Core/src/Authorization/Pipeline/AuthorizeRequestMiddleware.cs | Updates to use TryGetDocument. |
| src/All.slnx | Adds Diagnostics.Core project to the root solution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/HotChocolate/Diagnostics/src/Diagnostics.Core/Extensions/ActivityExtensions.cs
Show resolved
Hide resolved
src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/AnalyzeOperationComplexitySpan.cs
Outdated
Show resolved
Hide resolved
...otChocolate/Core/src/Execution.Abstractions/Execution/Extensions/RequestContextExtensions.cs
Show resolved
Hide resolved
src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/ValidationSpan.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.