Align with OTEL semantic conventions

src/All.slnx

@@ -173,6 +173,7 @@
   </Folder>
   <Folder Name="/HotChocolate/Diagnostics/" />
   <Folder Name="/HotChocolate/Diagnostics/src/">
+    <Project Path="HotChocolate/Diagnostics/src/Diagnostics.Core/HotChocolate.Diagnostics.Core.csproj" />
     <Project Path="HotChocolate/Diagnostics/src/Diagnostics/HotChocolate.Diagnostics.csproj" />
   </Folder>
   <Folder Name="/HotChocolate/Diagnostics/test/">

src/HotChocolate/Core/src/Execution.Abstractions/Path.cs

@@ -131,7 +131,7 @@ public string Print()
     {
         if (this is RootPathSegment)
         {
-            return "/";
+            return string.Empty;
         }
 
         // On first pass we calculate the total length
@@ -147,7 +147,11 @@ public string Print()
                     break;
 
                 case NamePathSegment name:
-                    totalLength += 1 + name.Name.Length; // '/' + name
+                    totalLength += name.Name.Length;
+                    if (current.Parent is not RootPathSegment)
+                    {
+                        totalLength++;
+                    }
                     break;
 
                 default:
@@ -158,10 +162,13 @@ public string Print()
         }
 
         // On second pass we fill from right to left using string.Create
-        return string.Create(totalLength, this, static (span, path) =>
+        return string.Create(
+            totalLength,
+            this,
+            static (span, state) =>
         {
             var pos = span.Length;
-            var current = path;
+            var current = state;
 
             while (current is not RootPathSegment)
             {
@@ -188,7 +195,10 @@ public string Print()
                     case NamePathSegment name:
                         pos -= name.Name.Length;
                         name.Name.AsSpan().CopyTo(span[pos..]);
-                        span[--pos] = '/';
+                        if (current.Parent is not RootPathSegment)
+                        {
+                            span[--pos] = '.';
+                        }
                         break;
                 }
 

src/HotChocolate/Core/src/Types/Execution/Instrumentation/AggregateExecutionDiagnosticEvents.cs

@@ -186,30 +186,6 @@ public IDisposable ExecuteOperation(RequestContext context)
         return new AggregateActivityScope(scopes);
     }
 
-    public IDisposable ExecuteStream(IOperation operation)
-    {
-        var scopes = new IDisposable[_listeners.Length];
-
-        for (var i = 0; i < _listeners.Length; i++)
-        {
-            scopes[i] = _listeners[i].ExecuteStream(operation);
-        }
-
-        return new AggregateActivityScope(scopes);
-    }
-
-    public IDisposable ExecuteDeferredTask()
-    {
-        var scopes = new IDisposable[_listeners.Length];
-
-        for (var i = 0; i < _listeners.Length; i++)
-        {
-            scopes[i] = _listeners[i].ExecuteDeferredTask();
-        }
-
-        return new AggregateActivityScope(scopes);
-    }
-
     public IDisposable ResolveFieldValue(IMiddlewareContext context)
     {
         if (_resolverListener.Length == 0)
@@ -235,14 +211,6 @@ public void ResolverError(IMiddlewareContext context, IError error)
         }
     }
 
-    public void ResolverError(RequestContext context, ISelection selection, IError error)
-    {
-        for (var i = 0; i < _listeners.Length; i++)
-        {
-            _listeners[i].ResolverError(context, selection, error);
-        }
-    }
-
     public IDisposable RunTask(IExecutionTask task)
     {
         if (_resolverListener.Length == 0)
@@ -316,18 +284,6 @@ public void SubscriptionEventError(RequestContext context, ulong subscriptionId,
         }
     }
 
-    public IDisposable DispatchBatch(RequestContext context)
-    {
-        var scopes = new IDisposable[_listeners.Length];
-
-        for (var i = 0; i < _listeners.Length; i++)
-        {
-            scopes[i] = _listeners[i].DispatchBatch(context);
-        }
-
-        return new AggregateActivityScope(scopes);
-    }
-
     public void ExecutorCreated(string name, IRequestExecutor executor)
     {
         for (var i = 0; i < _listeners.Length; i++)

src/HotChocolate/Core/src/Types/Execution/Instrumentation/IExecutionDiagnosticEvents.cs

@@ -79,29 +79,6 @@ public interface IExecutionDiagnosticEvents : ICoreExecutionDiagnosticEvents
     /// </returns>
     IDisposable CompileOperation(RequestContext context);
 
-    /// <summary>
-    /// Called within the execute operation scope when the result is a streamed result.
-    /// The ExecuteStream scope will run longer than the ExecuteOperation scope.
-    /// The ExecuteOperation scope completes once the initial operation is executed,
-    /// while all deferred elements are executed and delivered within the ExecuteStream scope.
-    /// </summary>
-    /// <param name="operation">
-    /// The compiled operation that is being streamed.
-    /// </param>
-    /// <returns>
-    /// A scope that will be disposed when the streaming execution has finished.
-    /// </returns>
-    IDisposable ExecuteStream(IOperation operation);
-
-    /// <summary>
-    /// Called when starting to execute a deferred part of an operation
-    /// within the ExecuteStream scope or ExecuteSubscription scope.
-    /// </summary>
-    /// <returns>
-    /// A scope that will be disposed when the deferred task execution has finished.
-    /// </returns>
-    IDisposable ExecuteDeferredTask();
-
     /// <summary>
     /// Called when starting to resolve a field value.
     /// </summary>
@@ -131,26 +108,6 @@ public interface IExecutionDiagnosticEvents : ICoreExecutionDiagnosticEvents
     /// </param>
     void ResolverError(IMiddlewareContext context, IError error);
 
-    /// <summary>
-    /// Called for field errors that occur outside the resolver task execution,
-    /// typically during result processing or validation.
-    /// </summary>
-    /// <param name="context">
-    /// The request context encapsulates all GraphQL-specific information about an
-    /// individual GraphQL request.
-    /// </param>
-    /// <param name="selection">
-    /// The field selection that is affected by the error.
-    /// </param>
-    /// <param name="error">
-    /// The error that occurred during field processing.
-    /// </param>
-    /// <remarks>
-    /// Some field-level errors are handled after the resolver completes and these
-    /// are processed in the request scope rather than the resolver scope.
-    /// </remarks>
-    void ResolverError(RequestContext context, ISelection selection, IError error);
-
     /// <summary>
     /// Called when starting to execute an execution engine task.
     /// </summary>
@@ -215,19 +172,4 @@ public interface IExecutionDiagnosticEvents : ICoreExecutionDiagnosticEvents
     /// individual GraphQL request.
     /// </param>
     void RetrievedOperationFromCache(RequestContext context);
-
-    /// <summary>
-    /// Called when the execution engine dispatches deferred execution batches.
-    /// During execution, components like DataLoader defer data resolver execution
-    /// to be processed in batches. When the execution engine has no immediate work,
-    /// these batches are dispatched for execution.
-    /// </summary>
-    /// <param name="context">
-    /// The request context encapsulates all GraphQL-specific information about an
-    /// individual GraphQL request.
-    /// </param>
-    /// <returns>
-    /// A scope that will be disposed when the batch dispatch has finished.
-    /// </returns>
-    IDisposable DispatchBatch(RequestContext context);
 }

src/HotChocolate/Core/test/Execution.Abstractions.Tests/ErrorBuilderTests.cs

@@ -192,7 +192,7 @@ public void SetPath_Foo_PathIsFooWithCount1()
             .Build();
 
         // assert
-        Assert.Equal("/foo", error.Path?.Print());
+        Assert.Equal("foo", error.Path?.Print());
     }
 
     [Fact]
@@ -206,7 +206,7 @@ public void SetPathObject_Foo_PathIsFooWithCount1()
             .Build();
 
         // assert
-        Assert.Equal("/foo", error.Path?.Print());
+        Assert.Equal("foo", error.Path?.Print());
     }
 
     [Fact]

src/HotChocolate/Core/test/Execution.Abstractions.Tests/ErrorTests.cs

@@ -204,6 +204,6 @@ public void WithPath()
         error = error.WithPath(Path.FromList(["foo"]));
 
         // assert
-        Assert.Equal("/foo", error.Path!.Print());
+        Assert.Equal("foo", error.Path!.Print());
     }
 }

src/HotChocolate/Core/test/Execution.Abstractions.Tests/PathTests.cs

@@ -28,7 +28,30 @@ public void Path_ToString()
         var result = path.ToString();
 
         // assert
-        Assert.Equal("/hero/friends[0]/name", result);
+        Assert.Equal("hero.friends[0].name", result);
+    }
+
+    [Fact]
+    public void Path_Print()
+    {
+        // arrange
+        var path = Path.Root.Append("person").Append(0).Append("address");
+
+        // act
+        var result = path.Print();
+
+        // assert
+        Assert.Equal("person[0].address", result);
+    }
+
+    [Fact]
+    public void Path_Print_Root()
+    {
+        // act
+        var result = Path.Root.Print();
+
+        // assert
+        Assert.Equal(string.Empty, result);
     }
 
     [Fact]
@@ -172,12 +195,12 @@ public void Complex_Ordering()
 
         string[] expected =
         [
-            "/bar",
-            "/bar[3]",
-            "/bar[3][2]",
-            "/bar[3]/foo",
-            "/foo",
-            "/foo[0]"
+            "bar",
+            "bar[3]",
+            "bar[3][2]",
+            "bar[3].foo",
+            "foo",
+            "foo[0]"
         ];
 
         for (var i = 0; i < paths.Length; i++)

src/HotChocolate/Core/test/Execution.Tests/ArgumentNonNullValidatorTests.cs

@@ -62,6 +62,6 @@ input Bar {
 
         // assert
         Assert.True(report.HasErrors);
-        Assert.Equal("/root/a", report.Path.ToString());
+        Assert.Equal("root.a", report.Path.ToString());
     }
 }

src/HotChocolate/Core/test/Types.Tests/Types/__snapshots__/DirectiveTypeTests.Directive_ValidateArgs_ArgMissing.snap

@@ -1,2 +1,2 @@
-The directive arguments have invalid values: 'The required input field `d` is missing.' at /d.
+The directive arguments have invalid values: 'The required input field `d` is missing.' at d.
 @a

src/HotChocolate/Core/test/Types.Tests/Types/__snapshots__/DirectiveTypeTests.Directive_ValidateArgs_InvalidArg.snap

@@ -1,2 +1,2 @@
-The directive arguments have invalid values: 'Int cannot coerce the given literal of type `BooleanValue` to a runtime value.' at /e.
+The directive arguments have invalid values: 'Int cannot coerce the given literal of type `BooleanValue` to a runtime value.' at e.
 @a(d: 1, e: true)

src/HotChocolate/Core/test/Types.Tests/Types/__snapshots__/DirectiveTypeTests.Directive_ValidateArgs_NonNullArgIsNull.snap

@@ -1,2 +1,2 @@
-The directive arguments have invalid values: 'Cannot accept null for non-nullable input.' at /d.
+The directive arguments have invalid values: 'Cannot accept null for non-nullable input.' at d.
 @a(d: null)

src/HotChocolate/Core/test/Types.Tests/Types/__snapshots__/DirectiveTypeTests.Directive_ValidateArgs_Overflow.snap

@@ -1,2 +1,2 @@
-The directive arguments have invalid values: 'Int cannot coerce the given literal of type `IntValue` to a runtime value.' at /d.
+The directive arguments have invalid values: 'Int cannot coerce the given literal of type `IntValue` to a runtime value.' at d.
 @a(d: 9223372036854775807)

src/HotChocolate/Diagnostics/HotChocolate.Diagnostics.slnx

@@ -1,6 +1,7 @@
 <Solution>
   <Folder Name="/src/">
     <Project Path="src/Diagnostics/HotChocolate.Diagnostics.csproj" />
+    <Project Path="src/Diagnostics.Core/HotChocolate.Diagnostics.Core.csproj" />
   </Folder>
   <Folder Name="/test/">
     <Project Path="test/Diagnostics.Tests/HotChocolate.Diagnostics.Tests.csproj" />