Skip to content

Add type hints #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ClementPinard
Copy link

Add type hints to the library. It makes it much easier to work with VSCode since you get the autocompletion.

Notes :

  • type hints are 3.8 style (aka very verbose) and might be much prettier if converted to 3.10 style
  • Some automatic formatting have been added, I will remove it
  • This is not typechecked by pyright or mypy. the type hints are only for information purpose. Maybe this could be put in a stub file instead ?

@ClementPinard
Copy link
Author

Hi, is this PR considered ?
Helped me a lot for auto completion, and would be nice to have it included in the pip package (which could use an update on HF's acclerate version dependency btw)

Cheers,
Clément

@Chris-hughes10
Copy link
Owner

Hi @ClementPinard, I believe that @bepuca was looking at this

@ClementPinard
Copy link
Author

Hi thanks @Chris-hughes10 don't hesistate to ping me if some changes are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants