Skip to content

Re-implement LSTM in PyTorch #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrisCummins opened this issue Aug 30, 2020 · 3 comments
Closed

Re-implement LSTM in PyTorch #124

ChrisCummins opened this issue Aug 30, 2020 · 3 comments
Labels
Machine Learning Anything relevant to //deeplearning/ml4pl/models Refactor
Milestone

Comments

@ChrisCummins
Copy link
Owner

TensorFlow is a heavy dependency, and only the LSTM baseline uses it

@ChrisCummins ChrisCummins added Machine Learning Anything relevant to //deeplearning/ml4pl/models Refactor labels Aug 30, 2020
@ChrisCummins ChrisCummins added this to the 1.0.0 milestone Aug 30, 2020
ChrisCummins added a commit that referenced this issue Aug 30, 2020
ChrisCummins added a commit that referenced this issue Aug 30, 2020
@anon767
Copy link

anon767 commented Feb 26, 2021

FWIW, I think it could be worth the effort to reimplement the GGNN in Pytorch Geometric. As it would shift a lot logic out of PrograML.

@ChrisCummins
Copy link
Owner Author

@anon767 Great idea, I would love this. The core ProGraML implementation is actually quite small, but there's a lot of work in custom data loaders, batchers, etc that could be delegated to another library.

Unfortunately I really don't have much bandwidth to work on this project right now, but contributions very welcome!.

Cheers,
Chris

@ChrisCummins
Copy link
Owner Author

Superseded by #178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Machine Learning Anything relevant to //deeplearning/ml4pl/models Refactor
Projects
None yet
Development

No branches or pull requests

2 participants