Skip to content

Performance regression in dataflow task scripts #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrisCummins opened this issue Nov 30, 2020 · 3 comments
Closed

Performance regression in dataflow task scripts #147

ChrisCummins opened this issue Nov 30, 2020 · 3 comments
Labels
Bug Something isn't working Machine Learning Anything relevant to //deeplearning/ml4pl/models Optimization Make it faster

Comments

@ChrisCummins
Copy link
Owner

#142 appears to have caused a large performance regression for the dataflow task GGNN loops.

Performance now: ~2 graphs / sec for training/validation, and ~12 graphs / sec for validation
Performance before: ? (need to repo)

@ChrisCummins ChrisCummins added Bug Something isn't working Machine Learning Anything relevant to //deeplearning/ml4pl/models Optimization Make it faster labels Nov 30, 2020
@sarathsankar
Copy link

Hi @ChrisCummins,

The number varies, while training earlier it was around 40 graphs/s.
For validation: 211 graphs/s
Since there was halting-issue earlier, I don't have a number for testing.
Hope, below screenshot may help you.

programl_reachability_test_halt

Regards,
Sarath KS

@ChrisCummins
Copy link
Owner Author

Excellent, thanks for that @sarathsankar. I'm going to be off-the-grid for a couple of weeks but will take a look as soon as I'm back. This is high priority, release blocking.

Cheers,
Chris

@ChrisCummins
Copy link
Owner Author

Superseded by #178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Machine Learning Anything relevant to //deeplearning/ml4pl/models Optimization Make it faster
Projects
None yet
Development

No branches or pull requests

2 participants