Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Sep 21, 2024

Warning: big diff incoming

Read description before looking at the diff, it will explain why so many files are changing.

Going to conflict with #573

Might conflict with #591

Type of Change

  • Refactoring

Description

  1. Increases synergy
  2. Fixes problems with packager not being double quoted and because of that it unquotes itself (shellcheck noticed that)
  3. fixes issues with newlines being created on interactive prints
  4. fixes an issue with the zsh script (shellcheck noticed that)
  5. multiple quoting fixes
  6. multiple formatting fixes

That's about it. Review carefully.

Testing

tested

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • My changes generate no errors/warnings/merge conflicts.

credits

@ghost ghost marked this pull request as draft September 21, 2024 20:14
@ghost ghost mentioned this pull request Sep 21, 2024
4 tasks
@adamperkowski
Copy link
Collaborator

Looked through every single changed line. Apart from what I've requested, great work. Thanks.

Nyx and others added 13 commits September 21, 2024 17:24
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
@ghost
Copy link
Author

ghost commented Sep 21, 2024

ready for merge

@ghost ghost marked this pull request as ready for review September 21, 2024 21:35
@adamperkowski
Copy link
Collaborator

Every single line approved.

@ghost ghost changed the title increase synergy between scripts increase synergy between scripts && fix every issue related to printf Sep 22, 2024
@ghost ghost changed the title increase synergy between scripts && fix every issue related to printf fix every issue related to printf && increase synergy between scripts Sep 22, 2024
@ghost ghost changed the title fix every issue related to printf && increase synergy between scripts fix every issue related to printf Sep 22, 2024
@ChrisTitusTech ChrisTitusTech merged commit cca2660 into ChrisTitusTech:main Sep 22, 2024
2 checks passed
@ghost ghost deleted the increasesynergybetweenscripts branch September 22, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants