Skip to content

Conversation

jeevithakannan2
Copy link
Contributor

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • Add --skip-confirmation flag to skip the confirmation prompt

preview

Testing

  • No issues while testing. Tested on Arch Linux

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@ghost
Copy link

ghost commented Oct 15, 2024

how exactly would this benefit user experience? they are not manually building from source, i dont see the need in this

@jeevithakannan2
Copy link
Contributor Author

jeevithakannan2 commented Oct 15, 2024

Running linutil with --skip-confirmation will skip confirmation prompts

@ghost
Copy link

ghost commented Oct 15, 2024

Running linutil with --skip-confirmation will skip confirmation prompts

not everyone is using the crates.io pkgs or the aur pkgs, we should convert this into a bind instead of relying on cli

@jeevithakannan2
Copy link
Contributor Author

Running linutil with --skip-confirmation will skip confirmation prompts

not everyone is using the crates.io pkgs or the aur pkgs, we should convert this into a bind instead of relying on cli

We can have both

@ghost
Copy link

ghost commented Oct 15, 2024

Running linutil with --skip-confirmation will skip confirmation prompts

not everyone is using the crates.io pkgs or the aur pkgs, we should convert this into a bind instead of relying on cli

We can have both

sgtm

Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@adamperkowski
Copy link
Collaborator

I'll push doc changes.

@jeevithakannan2
Copy link
Contributor Author

@adamperkowski Thanks

@jeevithakannan2
Copy link
Contributor Author

jeevithakannan2 commented Oct 31, 2024

@ChrisTitusTech The some of the old merged PRs didn't run cargo xtask docgen. Will do that in a separate PR. This PR does'nt have any issues.

@adamperkowski
Copy link
Collaborator

@ChrisTitusTech The some of the old merged PRs didn't run cargo xtask docgen. Will do that in a separate PR. This PR does'nt have any issues.

#889

@ChrisTitusTech ChrisTitusTech merged commit d033b0f into ChrisTitusTech:main Nov 7, 2024
2 checks passed
@jeevithakannan2 jeevithakannan2 deleted the skip-confirmation branch November 7, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants