fix(system-cleanup): failing with no orphan packages on arch

[infstate]

Type of Change

• New feature
• Bug fix
• Documentation update
• Refactoring
• Hotfix
• Security patch
• UI/UX improvement

Description

When running the system cleanup option on Arch Linux (pacman), if the user has no orphaned (unused) packages the command will return 1 so the TUI think it failed and aborts. The issue is (pacman -Qtdq). So I added a check which runs it first and if the command executes sucessfully (returns 0) then it will continue with cleanup.

I also added a output if it found any packages and if not it will let the user know it skipped. (see screenshot below)

Testing

I tested this on my Arch with pacman and it works. I also don't have any orphaned pkgs.

Impact

Without this check it will fail and not do the rest of the cleanup (logs, temp files, etc) and just aborts and skips the whole process because the control flow think it fail.

Issues / other PRs related

N/A

Additional Information

If anyone has any unused packages, check it it will detect it.

Checklist

• My code adheres to the coding and style guidelines of the project.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no errors/warnings/merge conflicts.

[adamperkowski]

No need for all that. Just remove 2>&1.

[infstate]

Alright, do you want to send a suggested change so I can approve it? Or I manually do it

[infstate]

It would still fail because its the return code of that command. Our TUI backend will abort.

[adamperkowski]

It would still fail because its the return code of that command. Our TUI backend will abort.

I meant still redirecting to /dev/null, just doing || true

[infstate]

Alright, looks good its working on my end

[adamperkowski]

Thanks